From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id yHMDFnDU1GTSqQAASxT56A (envelope-from ) for ; Thu, 10 Aug 2023 14:13:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 8L2+FXDU1GQQgwEA9RJhRA (envelope-from ) for ; Thu, 10 Aug 2023 14:13:36 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 08DE840035 for ; Thu, 10 Aug 2023 14:13:35 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=kjc3ZUj9; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691669616; a=rsa-sha256; cv=none; b=RdfzR9LtqRO1AyMSMhI6PJQ/dN4h01xaSaVna79v/HlSdZDqcJSW7zNMdtv+d6TdSCmJCw 7cO2KYQf2MqPMr5UhLm+NKB3fOCvAXE0WKrVZRx6Qmef7eH4eYhon2GKm6h83bRmFW5Ua7 HEG6/aasA0fwOJFVfcNR8tFI+A6FqQIOt4Br4c0urt+NzEX57u5gxOq/h1ZZO2bZ++sJ6f F+gzCW8yWDNTMUZG0cKDMwTCyhKQiTjcqF3Y5njo3M4v2gxg4m/paz4A9fIKIPC5+k22w6 PATXt9WugxdMZIVscwqHhQLzJQ4K73ct4XMX9YGQJsvJs1WG3/A+1+dcDExJTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691669616; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Hso1n7NRV3hwbpLRJFZuEL7XT5uqiAa8Os7tm5oKUSk=; b=OOIBLvEirCioRIhHNM81VOjh2eD9S3wfbRTEIS3A3YXK+5LkNq5/ppaU+N/1ZUutbur6gk 0lacRzUkUD0Cj5PbMG5AVSHx1mcRrGxhuwuXZSyGif5lqK61KClxLtybzmUbU8G82E/UjL QMf1eaNfQJO1Em8q9GpSWjxT62hvUaRvM4RDMFXiaP0k2c+8x1M/thH2UHZQz/G49KyxA4 NYE4Ay1XSPYQw1Hsdm8LxyqAo2hCg5x+domyvWO0uvXVGMDIxnrptIfkOmm/VLzuhWAFjo UMsIEwf30bH5/n7tqbknQCLXIWXN9TOUSuTqhtdlgcWwkvuOJb29h9Z0WNw5ug== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=kjc3ZUj9; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qU4XV-0001xU-Kb; Thu, 10 Aug 2023 08:13:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qU4XG-0001v0-RJ for guix-patches@gnu.org; Thu, 10 Aug 2023 08:13:05 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qU4XG-0004ml-JE for guix-patches@gnu.org; Thu, 10 Aug 2023 08:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qU4XG-0007vR-EN for guix-patches@gnu.org; Thu, 10 Aug 2023 08:13:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#61946] Go generated files Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Aug 2023 12:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61946 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Thomas Ieong Cc: 61946@debbugs.gnu.org Received: via spool by 61946-submit@debbugs.gnu.org id=B61946.169166955730428 (code B ref 61946); Thu, 10 Aug 2023 12:13:02 +0000 Received: (at 61946) by debbugs.gnu.org; 10 Aug 2023 12:12:37 +0000 Received: from localhost ([127.0.0.1]:41606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU4Wr-0007ui-EL for submit@debbugs.gnu.org; Thu, 10 Aug 2023 08:12:37 -0400 Received: from mail.boiledscript.com ([144.168.59.46]:45052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU4Wo-0007uY-8T for 61946@debbugs.gnu.org; Thu, 10 Aug 2023 08:12:36 -0400 Date: Thu, 10 Aug 2023 20:12:17 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1691669547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Hso1n7NRV3hwbpLRJFZuEL7XT5uqiAa8Os7tm5oKUSk=; b=kjc3ZUj9UQKDXG4dgjXalM+KeavU3UXCTVeR7u3+Koh1tdqxqS/Gnc/Yh5nJyOgDxC8uhZ GJvZGQGCkhsYD3YwTw4tG1Uy2gZc1RBEsNVCh/QzKfZ4ZP6O8+HkHCjE5QHcgLyD4tI/IQ WseeKrxURL/PIC2VFm+i6mrvgn5lVKQG9bdARvc45lsV5WTdjXJ2UkYqawKVpscoF//qj/ OY7tIVYKk0HOaCLRhjPXUuCnnicoHZEV/RWAKcR8rLGPI0wlKyvF3km21MXf+AtT1qzQ4g CsLdEzG6sapXpQecZYjhKLtYN86irr+CYIv4ddfscLTta+W5dTGGx4vDGfE49w== Message-ID: <87r0objdum.wl-hako@ultrarare.space> In-Reply-To: <87mt4sjjbo.fsf@free.fr> References: <87mt4sjjbo.fsf@free.fr>, MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches From: Hilton Chain via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.67 X-Migadu-Scanner: mx2.migadu.com X-Migadu-Queue-Id: 08DE840035 X-Spam-Score: -6.67 X-TUID: iYbjmOR/CtEF Hi Thomas, > I forgot to check for generated files in the go packages. > I did just that and there is indeed one file hash.go that is generated > in the parse and minify package. > > Taking care of this and resending later. go-github-com-tdewolff-minify-v2 has been available in Guix for a while (but not the minify command and its dependency). I have sent a patchset [1] to generate hash.go at build time. Can you update the series to base on it and current Guix? And I think dependencies not added to go-github-com-tdewolff-minify-v2 are only required by minify command, so there's no need to touch definition of the former, inherit and modify is sufficient. What do you think? Thanks [1]: