From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2PkTKdpw7mHLBgAAgWs5BA (envelope-from ) for ; Mon, 24 Jan 2022 10:26:50 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GB/AIdpw7mHyKQEAG6o9tA (envelope-from ) for ; Mon, 24 Jan 2022 10:26:50 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 18CE02C7E7 for ; Mon, 24 Jan 2022 10:26:49 +0100 (CET) Received: from localhost ([::1]:33196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBvcd-000291-6U for larch@yhetil.org; Mon, 24 Jan 2022 04:26:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBvaw-00024p-DC for guix-patches@gnu.org; Mon, 24 Jan 2022 04:25:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49180) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nBvaw-0006Pq-1g for guix-patches@gnu.org; Mon, 24 Jan 2022 04:25:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nBvav-0005cd-VZ for guix-patches@gnu.org; Mon, 24 Jan 2022 04:25:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53295] [PATCH] gnu: Add FFmpeg 5.0. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 24 Jan 2022 09:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53295 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 53295@debbugs.gnu.org Received: via spool by 53295-submit@debbugs.gnu.org id=B53295.164301625421530 (code B ref 53295); Mon, 24 Jan 2022 09:25:01 +0000 Received: (at 53295) by debbugs.gnu.org; 24 Jan 2022 09:24:14 +0000 Received: from localhost ([127.0.0.1]:42080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBva9-0005bC-Un for submit@debbugs.gnu.org; Mon, 24 Jan 2022 04:24:14 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:41944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBva9-0005b0-8a for 53295@debbugs.gnu.org; Mon, 24 Jan 2022 04:24:13 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C189F2FE; Mon, 24 Jan 2022 10:24:07 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qtej1erkQZzf; Mon, 24 Jan 2022 10:24:07 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id DCEC2BD; Mon, 24 Jan 2022 10:24:06 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Mon, 24 Jan 2022 10:24:06 +0100 In-Reply-To: (Leo Famulari's message of "Sun, 16 Jan 2022 00:35:21 -0500") Message-ID: <87pmohwkp5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: C189F2FE X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643016410; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=f9O4W7ECgB5T3zkyQbR8uZld9Yk1FZCXmZVes7nAt60=; b=fixd5GWQAhkvwk606aaJSXsHaniijTiUYCMtGzq1GbZM/ohV8VSLKVBXRI+OgPFfF7TIrA aUSgAWCPieAoH6I55xeYDsiKI0pVevwcZ63vO0uv9L9POZSS/AFfoH8n13XbrMTnnTl/TQ 46/aqsAOvW4bZ+oWbjLHhs80Rzp99EVjZxojB6En/A5J+t+6CDyfUPujdQ9fFFdIaMDLlq PmUV7WAYdc6D4dPxkhKElyFstKT29iJoa5OWry1pxu0L5Z4+F7VEAX9lyLYuIoTL1X3hK+ 5BlNideMsmJElN4ntAchrSKhgG5xTADM2gp+tdcms9HmGUQi+mMfSw2ku9gvSw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643016410; a=rsa-sha256; cv=none; b=hHnHjkY4JYJQuJ0iM25kZ+60+rFOuHO4RUQryTnLzdv3AF055E0i9V6COWv1A2MDKKT7Yh zhTAXRTBTgJkcaiT7YtM19QZqCSPimgivVgY1MwUMR7Uq4ENtEQLsb6FK0ECYvLeCd9B3b byymWG0QVtGoRKfmVLfoSo5IyqHGyBVirKFy+BWpvrgPSbVaYEDbY4KIGaWFrk3CdK65S/ EkKChAcZRM60qCTQWLj+o2o9Ns1GoeE1wdwmgcsef3Wva9OIKiEJA+UMcapOP/ksiqkxBQ 7neHyqAF0XiBIKD9nQa0u9+Z1IFWLlQBipdO8DP6bzwo2CPz/r+xN1jZ5B19aQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 18CE02C7E7 X-Spam-Score: -4.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: hZJ7TWQau41B Hi, Leo Famulari skribis: > Here's the new major release of FFmpeg. > > We can add it right away and move users over to it incrementally as we > test them =E2=80=94 having this new version is useful for people like me = who use > FFmpeg directly. > > Also, I always found our FFmpeg packages' use of inheritance to be > confusing when making changes to them, so I didn't use it here. > > * gnu/packages/video.scm (ffmpeg-5): New variable. Could you remove input labels? (I think =E2=80=98guix style=E2=80=99 can= =E2=80=99t help because of the conditional in the middle.) That said, it seems to me there=E2=80=99s a lot of duplication here compare= d to version 4. So I=E2=80=99d be in favor of inheriting from that one. Now, I agree that sometimes attempting to factorize every bit can lead to hard-to-read packages. Perhaps the solution is to duplicate and tweak just those bits where factorization would make things less clear? Thanks, Ludo=E2=80=99.