all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Miguel Ángel Arruga Vivas" <rosen644835@gmail.com>
To: Brendan Tildesley <mail@brendan.scot>
Cc: othacehe@gnu.org, 44027@debbugs.gnu.org
Subject: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed.
Date: Sun, 18 Oct 2020 17:52:00 +0200	[thread overview]
Message-ID: <87mu0jpm5b.fsf@gmail.com> (raw)
In-Reply-To: <d0dc7a9d-1218-0814-8ed9-e0ace867c517@brendan.scot> (Brendan Tildesley's message of "Sun, 18 Oct 2020 15:07:05 +1100")

Hi!

Brendan Tildesley <mail@brendan.scot> writes:
> On 17/10/20 11:09 pm, Miguel Ángel Arruga Vivas wrote:
>> [...]
>> The attached patch solves that.  What do you think?
>>
>> Happy hacking,
>> Miguel
>
> I have tested the patch and the Installer mostly worked. One thing I
> noticed is that the partition scheme I was given automatically looks 
> like this:
>
> 1 537MB fat32 boot,esp /boot/efi EFI System Partition
> 2 3146Kb ext4 bios_grub
> 3 2001MB linux-swap
> 4 37.5GB ext4 /
>
> It is creating the bios_grub partition, but the EFI is still being
> made also. Is that necessary?

AFAIU from the code, the first partition should not be created by the
installer but it won't be removed if it was found on the disk
beforehand.  Tomorrow I'll give a try at the full installation process,
I must have overlooked something if it still being created in that
case...

Happy hacking!
Miguel




  reply	other threads:[~2020-10-18 15:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16  8:03 bug#44027: 1.2-29a2eb3 Installer fails at final stage installing GRUB Brendan Tildesley
2020-10-16 14:32 ` Ludovic Courtès
2020-10-16 22:55   ` Brett Gilio
2020-10-17 13:09     ` bug#44027: [PATCH] installer: Create bios_grub partition when it is needed Miguel Ángel Arruga Vivas
2020-10-18  2:02       ` Brendan Tildesley
2020-10-18  4:07       ` Brendan Tildesley
2020-10-18 15:52         ` Miguel Ángel Arruga Vivas [this message]
2020-10-18 17:03           ` Mathieu Othacehe
2020-10-19  5:57             ` Brendan Tildesley
2020-10-19 10:48               ` Mathieu Othacehe
2020-10-19 13:21                 ` Miguel Ángel Arruga Vivas
2020-10-19 15:51                   ` Mathieu Othacehe
2020-10-19 19:59                     ` Miguel Ángel Arruga Vivas
2020-10-20  5:33               ` Bengt Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mu0jpm5b.fsf@gmail.com \
    --to=rosen644835@gmail.com \
    --cc=44027@debbugs.gnu.org \
    --cc=mail@brendan.scot \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.