all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Brendan Tildesley <mail@brendan.scot>
To: "Miguel Ángel Arruga Vivas" <rosen644835@gmail.com>,
	"Brett Gilio" <brettg@gnu.org>
Cc: othacehe@gnu.org, 44027@debbugs.gnu.org
Subject: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed.
Date: Sun, 18 Oct 2020 13:02:20 +1100	[thread overview]
Message-ID: <418d612d-ef7c-ea58-2df2-80e4bb73ed4b@brendan.scot> (raw)
In-Reply-To: <87pn5hq9rs.fsf_-_@gmail.com>

On 17/10/20 11:09 pm, Miguel Ángel Arruga Vivas wrote:
> Hi,
>
> Brett Gilio <brettg@gnu.org> writes:
>> Ludovic Courtès <ludo@gnu.org> writes:
>>> Shouldn’t it create a “legacy” partition table rather than GPT since
>>> we’re on an old, non-UEFI platform?
>> That is my thinking as well, it should create a legacy MBR table.
> IMHO the old format should be avoided completely when possible.  Why
> should we enforce it?
>
> I think this problem involves having a previous ESP partition on the
> disk (at least identified as such by parted), because auto-partition!
> currently checks that before checking if the booted system has EFI
> support.  When that's the case, it doesn't create the needed bios_grub
> partition that might have been removed previously.
>
> The attached patch solves that.  What do you think?
>
> Happy hacking,
> Miguel

I'm about to give it a test run. Unrelated to the patch, but, I'm 
building the installer (gnu/system/install.scm) on latest master and I 
get the following warnings/errors, although it doesn't stop the build 
from completing. is it a bug?

https://paste.debian.net/plain/1167398




  reply	other threads:[~2020-10-18  2:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16  8:03 bug#44027: 1.2-29a2eb3 Installer fails at final stage installing GRUB Brendan Tildesley
2020-10-16 14:32 ` Ludovic Courtès
2020-10-16 22:55   ` Brett Gilio
2020-10-17 13:09     ` bug#44027: [PATCH] installer: Create bios_grub partition when it is needed Miguel Ángel Arruga Vivas
2020-10-18  2:02       ` Brendan Tildesley [this message]
2020-10-18  4:07       ` Brendan Tildesley
2020-10-18 15:52         ` Miguel Ángel Arruga Vivas
2020-10-18 17:03           ` Mathieu Othacehe
2020-10-19  5:57             ` Brendan Tildesley
2020-10-19 10:48               ` Mathieu Othacehe
2020-10-19 13:21                 ` Miguel Ángel Arruga Vivas
2020-10-19 15:51                   ` Mathieu Othacehe
2020-10-19 19:59                     ` Miguel Ángel Arruga Vivas
2020-10-20  5:33               ` Bengt Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=418d612d-ef7c-ea58-2df2-80e4bb73ed4b@brendan.scot \
    --to=mail@brendan.scot \
    --cc=44027@debbugs.gnu.org \
    --cc=brettg@gnu.org \
    --cc=othacehe@gnu.org \
    --cc=rosen644835@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.