From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cIgNEyRljF9HCgAA0tVLHw (envelope-from ) for ; Sun, 18 Oct 2020 15:54:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SLoCDyRljF9ufQAAB5/wlQ (envelope-from ) for ; Sun, 18 Oct 2020 15:54:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D5FB59400EF for ; Sun, 18 Oct 2020 15:54:11 +0000 (UTC) Received: from localhost ([::1]:49112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUB0b-00067X-MJ for larch@yhetil.org; Sun, 18 Oct 2020 11:54:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUB0T-00067K-Vt for bug-guix@gnu.org; Sun, 18 Oct 2020 11:54:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55609) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUB0T-0003Vv-MV for bug-guix@gnu.org; Sun, 18 Oct 2020 11:54:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUB0T-0001M1-Kr for bug-guix@gnu.org; Sun, 18 Oct 2020 11:54:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#44027: [PATCH] installer: Create bios_grub partition when it is needed. Resent-From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 18 Oct 2020 15:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44027 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Brendan Tildesley Received: via spool by 44027-submit@debbugs.gnu.org id=B44027.16030363835120 (code B ref 44027); Sun, 18 Oct 2020 15:54:01 +0000 Received: (at 44027) by debbugs.gnu.org; 18 Oct 2020 15:53:03 +0000 Received: from localhost ([127.0.0.1]:38922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUAzX-0001KW-0T for submit@debbugs.gnu.org; Sun, 18 Oct 2020 11:53:03 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:37510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUAzV-0001Jz-Ll for 44027@debbugs.gnu.org; Sun, 18 Oct 2020 11:53:02 -0400 Received: by mail-wm1-f67.google.com with SMTP id j136so10277992wmj.2 for <44027@debbugs.gnu.org>; Sun, 18 Oct 2020 08:53:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=F0tC+P25p0yEpf+e0lIUKYS6YUrpKOxWr9zk2WQ7kVI=; b=J1ExnkDo0z+SVE/uEw5wxEWsqdRVyU4MxiO2t/J7o0OVcOnF6FIvhwOHFA2O0XH9GJ vYAuaNi67koB2JzHM63kDgy1au4d3gkVdYf4yvndzLiDTIVuqOSnX8gAe4/5n+UOXIMs N3a4X1vYS2ARXGKi0yqGU/dT0nkWLyazHqOlvqDgnwLZ6Eq0V9NWbhfT/6Je4fOg235D sf98dSArImRqH2Qb6PAmcoxWJgEO6OoieTufKQA7UPi5AJ5GvInHm0v9PzRH0TJIhNiE gpcu3X4/8ORw531WpIsoedSueOePYfUCYHQ6uTrdssj/mbV4MPj001Z/4/JhuK9xfO/j BFzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=F0tC+P25p0yEpf+e0lIUKYS6YUrpKOxWr9zk2WQ7kVI=; b=VN8aWYbwqRvKO/Jp09AzFNePoUtExC/zQyfiEOKX/xg7Sbwku5a7nAyi96Mb7gMyeH VxNdyfJ/d93ptEydWP0juODe1tNc/BoUQMTQ8xl6R5PbwvGle2pqS3XQWapCn0MgTXFo BMyjgjBuf6mpBjrfg6pFhdcalf05ozddaKtrkiYlcbqcDo7wTeyE1AepAVn2qK9SJefh sHH/5fSTFTyp7DZcxFIFYtOohY1bReMZQjIQ0qQTy/0iqBekZLGEZp8O0X4KmjfXdab4 1Q6uXXVZE/sIsf+dlpXkn1fFuF/1QbR2w8k/zJM+JWVKciWuZLWnoNdiG8OkWRIl6DWk cT/Q== X-Gm-Message-State: AOAM532IoQWf/OOaemJMvfmWeGwtlN84bdzzF6LM9PMiKYrZsRYMpuPc dzEHNM+PwdZba21Vr+B8BFcFO0+gYR7C6kCO X-Google-Smtp-Source: ABdhPJzBa9+Qb4joRCYFTgAXrj2AkKooGGqReKTmTjf1fjYBYX/VDI3NVjeop5JUZNOiWQgJ1SsKQg== X-Received: by 2002:a1c:2d8f:: with SMTP id t137mr13214373wmt.26.1603036375442; Sun, 18 Oct 2020 08:52:55 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id p13sm13161277wmb.5.2020.10.18.08.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2020 08:52:54 -0700 (PDT) From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas References: <76f35a63-62e8-4653-865b-b14bb273db34@brendan.scot> <87lfg65jho.fsf@gnu.org> <878sc5wzld.fsf@debian> <87pn5hq9rs.fsf_-_@gmail.com> Date: Sun, 18 Oct 2020 17:52:00 +0200 In-Reply-To: (Brendan Tildesley's message of "Sun, 18 Oct 2020 15:07:05 +1100") Message-ID: <87mu0jpm5b.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.8 (/) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: othacehe@gnu.org, 44027@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=J1ExnkDo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: pIadOvC59lVu Hi! Brendan Tildesley writes: > On 17/10/20 11:09 pm, Miguel =C3=81ngel Arruga Vivas wrote: >> [...] >> The attached patch solves that. What do you think? >> >> Happy hacking, >> Miguel > > I have tested the patch and the Installer mostly worked. One thing I > noticed is that the partition scheme I was given automatically looks=20 > like this: > > 1 537MB fat32 boot,esp /boot/efi EFI System Partition > 2 3146Kb ext4 bios_grub > 3 2001MB linux-swap > 4 37.5GB ext4 / > > It is creating the bios_grub partition, but the EFI is still being > made also. Is that necessary? AFAIU from the code, the first partition should not be created by the installer but it won't be removed if it was found on the disk beforehand. Tomorrow I'll give a try at the full installation process, I must have overlooked something if it still being created in that case... Happy hacking! Miguel