From: Brice Waegeneire <brice@waegenei.re>
To: Xinglu Chen <public@yoctocell.xyz>
Cc: 49058@debbugs.gnu.org
Subject: [bug#49058] [PATCH] gnu: Add duc.
Date: Sat, 19 Jun 2021 22:10:46 +0200 [thread overview]
Message-ID: <87mtrly5rt.fsf_-_@waegenei.re> (raw)
In-Reply-To: <87a6nn6yio.fsf@yoctocell.xyz> (Xinglu Chen's message of "Fri, 18 Jun 2021 16:25:03 +0200")
Hello Xinglu,
Thank you for the review!
Xinglu Chen <public@yoctocell.xyz> writes:
> The trailing #t can be dropped, phases don’t need to end with #t once
> the ‘core-updates’ branch gets merged (hopefully soon :)).
Removed.
>> + (description " Duc maintains a database of accumulated sizes of
> ^^
> Redundant whitespace
Fixed. I wanted to to factorize your checker
`check-no-trailing-whitespace description` to include leading
whitespaces but I didn't find how to does it nicely.
>> + (license license:lgpl3+)
>> + (home-page "http://duc.zevv.nl")))
>
> Nit: the ‘home-page’ field usually comes before ‘synopsis’
Moved over synopsis.
> Otherwise, LGTM.
Pused as 9fd9364492b95baf48baf054a326145fde5bc21b.
Cheers,
- Bricec
next prev parent reply other threads:[~2021-06-19 20:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 6:43 [bug#49058] [PATCH] gnu: Add duc Brice Waegeneire
2021-06-18 14:25 ` Xinglu Chen
2021-06-19 20:10 ` Brice Waegeneire [this message]
2021-06-19 20:52 ` Xinglu Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtrly5rt.fsf_-_@waegenei.re \
--to=brice@waegenei.re \
--cc=49058@debbugs.gnu.org \
--cc=public@yoctocell.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.