all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Xinglu Chen <public@yoctocell.xyz>
To: Brice Waegeneire <brice@waegenei.re>, 49058@debbugs.gnu.org
Subject: [bug#49058] [PATCH] gnu: Add duc.
Date: Fri, 18 Jun 2021 16:25:03 +0200	[thread overview]
Message-ID: <87a6nn6yio.fsf@yoctocell.xyz> (raw)
In-Reply-To: <20210616064352.13688-1-brice@waegenei.re>

[-- Attachment #1: Type: text/plain, Size: 2534 bytes --]

On Wed, Jun 16 2021, Brice Waegeneire wrote:

> +(define-public duc
> +  (package
> +    (name "duc")
> +    (version "1.4.4")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/zevv/duc")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1i7ry25xzy027g6ysv6qlf09ax04q4vy0kikl8h0aq5jbxsl9q52"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out")))
> +               (substitute* "src/duc/cmd-ui.c"
> +                 (("ncursesw/ncurses.h") "ncurses.h"))
> +               (substitute* "examples/index.cgi"
> +                 (("/usr/local/bin/duc")
> +                  (string-append out "/bin/duc")))
> +               #t)))

The trailing #t can be dropped, phases don’t need to end with #t once
the ‘core-updates’ branch gets merged (hopefully soon :)).

> +         (add-after 'install 'install-examples
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let* ((out (assoc-ref outputs "out"))
> +                    (doc (string-append out "/share/doc/" ,name "-" ,version)))
> +               (copy-recursively "examples" (string-append doc "/examples"))))))))
> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("cairo" ,cairo)
> +       ("pango" ,pango)
> +       ("tokyocabinet" ,tokyocabinet)
> +       ("ncurses" ,ncurses)))
> +    (synopsis "Library and suite of tools for inspecting disk usage")
> +    (description " Duc maintains a database of accumulated sizes of
                    ^^
Redundant whitespace

> +directories of the file system, and allows you to query this database with
> +some tools, or create fancy graphs showing you where your bytes are.
> +
> +Duc comes with console utilities, ncurses and X11 user interfaces and a CGI
> +wrapper for disk usage querying and visualisation.")
> +    (license license:lgpl3+)
> +    (home-page "http://duc.zevv.nl")))

Nit: the ‘home-page’ field usually comes before ‘synopsis’

Otherwise, LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2021-06-18 14:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16  6:43 [bug#49058] [PATCH] gnu: Add duc Brice Waegeneire
2021-06-18 14:25 ` Xinglu Chen [this message]
2021-06-19 20:10   ` Brice Waegeneire
2021-06-19 20:52     ` Xinglu Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6nn6yio.fsf@yoctocell.xyz \
    --to=public@yoctocell.xyz \
    --cc=49058@debbugs.gnu.org \
    --cc=brice@waegenei.re \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.