From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id G5suAXNPzmD9AQAAgWs5BA (envelope-from ) for ; Sat, 19 Jun 2021 22:11:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 2O27N3JPzmC7WwAAbx9fmQ (envelope-from ) for ; Sat, 19 Jun 2021 20:11:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2D11325485 for ; Sat, 19 Jun 2021 22:11:24 +0200 (CEST) Received: from localhost ([::1]:47260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luhJK-0002Lu-NE for larch@yhetil.org; Sat, 19 Jun 2021 16:11:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luhJ0-0002K6-Tz for guix-patches@gnu.org; Sat, 19 Jun 2021 16:11:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49312) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luhJ0-0000YF-I5 for guix-patches@gnu.org; Sat, 19 Jun 2021 16:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1luhIz-00071I-MA for guix-patches@gnu.org; Sat, 19 Jun 2021 16:11:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49058] [PATCH] gnu: Add duc. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 19 Jun 2021 20:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49058 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 49058@debbugs.gnu.org Received: via spool by 49058-submit@debbugs.gnu.org id=B49058.162413345926974 (code B ref 49058); Sat, 19 Jun 2021 20:11:01 +0000 Received: (at 49058) by debbugs.gnu.org; 19 Jun 2021 20:10:59 +0000 Received: from localhost ([127.0.0.1]:60858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luhIx-00070z-3P for submit@debbugs.gnu.org; Sat, 19 Jun 2021 16:10:59 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:6029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luhIu-00070j-DN for 49058@debbugs.gnu.org; Sat, 19 Jun 2021 16:10:57 -0400 Received: (Authenticated sender: brice@waegenei.re) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 360A9240005; Sat, 19 Jun 2021 20:10:48 +0000 (UTC) From: Brice Waegeneire References: <20210616064352.13688-1-brice@waegenei.re> <87a6nn6yio.fsf@yoctocell.xyz> Date: Sat, 19 Jun 2021 22:10:46 +0200 In-Reply-To: <87a6nn6yio.fsf@yoctocell.xyz> (Xinglu Chen's message of "Fri, 18 Jun 2021 16:25:03 +0200") Message-ID: <87mtrly5rt.fsf_-_@waegenei.re> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624133486; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=PENdVLDcrQSeLy6JRBQb/GZWmyNk50FmX7S20eP1WKY=; b=pDZoiW0JjldnpO+q6CsmwAgiF4Fem3OgEChuwE51NNZYP+BMAym7v0OMcCYLL3kKPD5r2U AgafuCoA3yXp6FJdEoM9d76bVHxk9Hp9oo8zcBIole4YB6P1GZ2su9teC/u9d58J5kxZrh jnPiC5kbzUoRxESX2xm9ZWSiCi8kDL9fdZ63dlqyCIvH0YffBQlnMe9xrSepSq/aNT2x49 Y5t/Nai7GZS2CiZUmz2PwmKj/SBf7KaAwIlSGmXDFA6M0pqhgMYg8ZW7xGIwWG82haFsWH PysOStbS71aeUSL7eIFSaaGbr7suXalAWQf7Ukas47ibbS35TlMWIVHfPfMG3g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624133486; a=rsa-sha256; cv=none; b=OHf8jLlrx5sOqIfz1aQCzHo83LdQKHSPhRqrx2q9SPMcvZiYCgsI3iwdKAqHDwoc6LMOcN CDugO4naREsQKZLuqkjhi8E4bEBXmDsfF1dLsRpkuxTSkZ/8ybBPk+OBL/Dq3WMKiF8Mof 2b+WQsbsi2hYIggOs9JnwjnR1zBVTkWN+7nI3V1yc6ALFovZTZx5Ls8JX/GjwrHh33kyFy qWz5ejngrHzgDaDMJB4LidEP1JV3t2KvS2HuAPBsrKlV9g1ts3m8lF5B0z20PD4mpqTRgH UDGvw/gS37v22GYmoaaoSma3wrli5xY6QKEGgY5maS9bR4xlhituxekID4kBCg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 2D11325485 X-Spam-Score: -1.01 X-Migadu-Scanner: scn1.migadu.com X-TUID: /W5mvJfJe/dj Hello Xinglu, Thank you for the review! Xinglu Chen writes: > The trailing #t can be dropped, phases don=E2=80=99t need to end with #t = once > the =E2=80=98core-updates=E2=80=99 branch gets merged (hopefully soon :)). Removed. >> + (description " Duc maintains a database of accumulated sizes of > ^^ > Redundant whitespace Fixed. I wanted to to factorize your checker `check-no-trailing-whitespace description` to include leading whitespaces but I didn't find how to does it nicely. >> + (license license:lgpl3+) >> + (home-page "http://duc.zevv.nl"))) > > Nit: the =E2=80=98home-page=E2=80=99 field usually comes before =E2=80=98= synopsis=E2=80=99 Moved over synopsis. > Otherwise, LGTM. Pused as 9fd9364492b95baf48baf054a326145fde5bc21b. Cheers, - Bricec