all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org
Subject: Re: broken references in jar manifests
Date: Tue, 20 Mar 2018 14:47:41 +0100	[thread overview]
Message-ID: <87lgemdfk2.fsf@elephly.net> (raw)
In-Reply-To: <20180320131418.70989741@scratchpost.org>


Danny Milosavljevic <dannym@scratchpost.org> writes:

> Hi Julien,
>
> On Tue, 20 Mar 2018 11:50:51 +0100
> julien lepiller <julien@lepiller.eu> wrote:
>
>> The issue is with grafts here: the plain file with full reference to the
>> store
>> gets grafted and contains the new entry. The Manifest will not be
>> updated because
>> of line breaks, and Java will still look for the version in the
>> manifest. The GC
>> will collect it because it doesn't see any reference to the old version
>> in any
>> file (because of line breaks), and the package is broken.
>
> Oh okay, so there are two problems.

Well, they are closely related.  One is that we don’t keep references
because they are broken up in the manifest; this is a minor problem,
because we can propagate inputs.  The more important problem is that it
breaks grafts.

> (The specification says that INDEX.LIST is preferred if it exists)

Interesting.  It’s worth playing with it.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

  reply	other threads:[~2018-03-20 14:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 17:11 broken references in jar manifests Ricardo Wurmus
2018-03-01 18:32 ` Gábor Boskovits
2018-03-01 18:54   ` Ricardo Wurmus
2018-03-01 19:08     ` Gábor Boskovits
2018-03-01 19:52       ` Ricardo Wurmus
2018-03-19  4:24       ` Chris Marusich
2018-03-19  4:47         ` Ricardo Wurmus
2018-03-02 13:18 ` Ludovic Courtès
2018-03-20 10:28   ` Danny Milosavljevic
2018-03-20 10:50     ` julien lepiller
2018-03-20 12:14       ` Danny Milosavljevic
2018-03-20 13:47         ` Ricardo Wurmus [this message]
2018-03-21 21:07         ` Danny Milosavljevic
2018-03-21 22:58           ` Ricardo Wurmus
2018-03-25 10:19           ` [PATCH] Create INDEX.LIST; Was: Fix " Danny Milosavljevic
2018-04-01 22:12             ` Chris Marusich
2018-04-18 13:25               ` Danny Milosavljevic
2018-05-06 18:09               ` Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lgemdfk2.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.