From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: broken references in jar manifests
Date: Fri, 02 Mar 2018 14:18:09 +0100 [thread overview]
Message-ID: <87zi3qfwfi.fsf@gnu.org> (raw)
In-Reply-To: <idjpo4n3elc.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's message of "Thu, 1 Mar 2018 18:11:59 +0100")
Heya,
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
> Manifest-Version: 1.0
> Class-Path: /gnu/store/i28vi94r8z9f0x02zgkrv87w16ibmqkw-java-htsjdk-2.
> 10.1/share/java/htsjdk.jar
> Created-By: 1.8.0_151 (Oracle Corporation)
> Main-Class: picard.cmdline.PicardCommandLine
>
> Note that the Class-Path property is broken into two lines. This means
> that the reference scanner will miss it and grafting will fail.
>
> Breaking up lines longer than 70 characters is according to the manifest
> specification, see
> https://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html
What would happen if we modified the tool that generates these to no
break lines? Buffer overflow in the class loader?
> 1) we need to patch the JDK
> 2) the jars would not do the right thing when executed with a different
> JDK (e.g. on a foreign distro).
Does #2 really matter? Those jars won’t work on non-Guix systems anyway
precisely because they contain references to the store.
> An alternative to recording full references in the manifest file is to
> install a “lib” directory that contains symlinks to dependencies. The
> manifest can then contain relative paths to these symlinks.
Very smart and easy to do, no? To my untrained eye, this looks like the
winning option here. :-)
Thanks,
Ludo’.
next prev parent reply other threads:[~2018-03-02 13:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 17:11 broken references in jar manifests Ricardo Wurmus
2018-03-01 18:32 ` Gábor Boskovits
2018-03-01 18:54 ` Ricardo Wurmus
2018-03-01 19:08 ` Gábor Boskovits
2018-03-01 19:52 ` Ricardo Wurmus
2018-03-19 4:24 ` Chris Marusich
2018-03-19 4:47 ` Ricardo Wurmus
2018-03-02 13:18 ` Ludovic Courtès [this message]
2018-03-20 10:28 ` Danny Milosavljevic
2018-03-20 10:50 ` julien lepiller
2018-03-20 12:14 ` Danny Milosavljevic
2018-03-20 13:47 ` Ricardo Wurmus
2018-03-21 21:07 ` Danny Milosavljevic
2018-03-21 22:58 ` Ricardo Wurmus
2018-03-25 10:19 ` [PATCH] Create INDEX.LIST; Was: Fix " Danny Milosavljevic
2018-04-01 22:12 ` Chris Marusich
2018-04-18 13:25 ` Danny Milosavljevic
2018-05-06 18:09 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi3qfwfi.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.