From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: broken references in jar manifests Date: Tue, 20 Mar 2018 14:47:41 +0100 Message-ID: <87lgemdfk2.fsf@elephly.net> References: <87zi3qfwfi.fsf@gnu.org> <20180320112855.33d86b6f@scratchpost.org> <6b4b40b375cc973d19a4ccfa14d011e1@lepiller.eu> <20180320131418.70989741@scratchpost.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyIKN-0007sQ-0O for guix-devel@gnu.org; Tue, 20 Mar 2018 10:33:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyIKI-0008EN-Sa for guix-devel@gnu.org; Tue, 20 Mar 2018 10:33:27 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21114) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyIKI-0008Cd-Ha for guix-devel@gnu.org; Tue, 20 Mar 2018 10:33:22 -0400 In-reply-to: <20180320131418.70989741@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org Danny Milosavljevic writes: > Hi Julien, > > On Tue, 20 Mar 2018 11:50:51 +0100 > julien lepiller wrote: > >> The issue is with grafts here: the plain file with full reference to the >> store >> gets grafted and contains the new entry. The Manifest will not be >> updated because >> of line breaks, and Java will still look for the version in the >> manifest. The GC >> will collect it because it doesn't see any reference to the old version >> in any >> file (because of line breaks), and the package is broken. > > Oh okay, so there are two problems. Well, they are closely related. One is that we don=E2=80=99t keep referenc= es because they are broken up in the manifest; this is a minor problem, because we can propagate inputs. The more important problem is that it breaks grafts. > (The specification says that INDEX.LIST is preferred if it exists) Interesting. It=E2=80=99s worth playing with it. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net