Re: 01/01: tests: docker: Run a guest guile inside the docker container.

Re: 01/01: tests: docker: Run a guest guile inside the docker container.

[Mark H Weaver]

Hi Danny,

guix-commits@gnu.org writes:

> dannym pushed a commit to branch master
> in repository guix.
>
> commit 49ec5d88c5770ae49b45849cb691c8921ecf4ca7
> Author: Danny Milosavljevic <dannym@scratchpost.org>
> Date:   Mon Jan 14 15:44:16 2019 +0100
>
>     tests: docker: Run a guest guile inside the docker container.
>     
>     * gnu/tests/docker.scm (run-docker-test): Add parameters.  Load and run
>     docker container.  Check response of guest guile.
>     (build-tarball&run-docker-test): New procedure.
>     (%test-docker): Use it.
>     [description]: Modify.

[...]

> +(define (build-tarball&run-docker-test)
> +  (mlet* %store-monad
> +      ((_ (set-grafting #f))
> +       (guile (set-guile-for-build (default-guile)))
> +       (guest-script-package ->
> +        (dummy-package "guest-script"
> +                       (build-system trivial-build-system)

This introduces a duplicate field initializer in the expanded 'package'
object, because the 'dummy-package' macro introduces its own
'build-system' field initializer.  From (guix tests):

  (define-syntax-rule (dummy-package name* extra-fields ...)
    "Return a \"dummy\" package called NAME*, with all its compulsory fields
  initialized with default values, and with EXTRA-FIELDS set as specified."
    (package extra-fields ...
             (name name*) (version "0") (source #f)
             (build-system gnu-build-system)
             (synopsis #f) (description #f)
             (home-page #f) (license #f)))

If you need to use trivial-build-system, then I think you can't use the
'dummy-package' macro as it's currently implemented.

      Regards,
        Mark

Re: 01/01: tests: docker: Run a guest guile inside the docker container.

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

Hi Mark,

fixed in commit 69e47686c9a8a2b5c4ee33e5b14da657de3d7ca0.

P.S. I copied that from other tests, so those are also broken
in the same way.  These are in these files:

* tests/gexp.scm
* tests/guix-build.sh
* tests/profiles.scm
* tests/packages.scm

The ones using the original definition are in these files:

* tests/crate.scm
* tests/graph.scm
* tests/guix-build.sh
* tests/lint.scm
* tests/profiles.scm
* tests/pypi.scm
* tests/scripts-build.scm
* tests/packages.scm

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: 01/01: tests: docker: Run a guest guile inside the docker container.

[Ludovic Courtès]

Hi Mark,

Mark H Weaver <mhw@netris.org> skribis:

> This introduces a duplicate field initializer in the expanded 'package'
> object, because the 'dummy-package' macro introduces its own
> 'build-system' field initializer.  From (guix tests):
>
>   (define-syntax-rule (dummy-package name* extra-fields ...)
>     "Return a \"dummy\" package called NAME*, with all its compulsory fields
>   initialized with default values, and with EXTRA-FIELDS set as specified."
>     (package extra-fields ...
>              (name name*) (version "0") (source #f)
>              (build-system gnu-build-system)
>              (synopsis #f) (description #f)
>              (home-page #f) (license #f)))

I realized I must have used the same idiom in some of the unit tests.
Did you catch anything there, Mark?

Ludo’.