bug#45015: [mumi] 44964 cannot be displayed

bug#45015: [mumi] 44964 cannot be displayed

[Ricardo Wurmus]

Display of issue 44964 fails because the email address is not properly
split.

--8<---------------cut here---------------start------------->8---
GET /44964
In mumi/web/server.scm:
     33:9  9 (handler _ _)
In mumi/web/controller.scm:
   122:24  8 (_ _)
In mumi/web/view/html.scm:
    358:2  7 (issue-page #<<bug-status> num: 44964 archived: #f bloâ¦> â¦)
In unknown file:
           6 (filter #<procedure 7f19e5295440 at mumi/web/view/htmlâ¦> â¦)
In mumi/web/view/html.scm:
   363:24  5 (_ _)
In mumi/messages.scm:
    142:8  4 (internal-message? _)
In unknown file:
           3 (_ #<procedure 7f174074bfe0 at ice-9/boot-9.scm:792:28â¦> â¦)
In mumi/messages.scm:
     88:6  2 (sender _)
In unknown file:
           1 (car "Jorge P. de Morais Neto <jorge+list@disroot.org>")
In ice-9/boot-9.scm:
  1669:16  0 (raise-exception _ #:continuable? _)
--8<---------------cut here---------------end--------------->8---


-- 
Ricardo

bug#45015: [mumi] 44964 cannot be displayed

[Ricardo Wurmus]

Mumi commit 6fd49e9341d5673b70edfb333a4e5fa0a44128d2 works around this
problem, which I suspect might be a bug in guile-email.

For some reason “Jorge P. de Morais Neto <jorge+list@disroot.org>” is
not split up into name and address parts but remains a single string.

-- 
Ricardo

bug#45015: [mumi] 44964 cannot be displayed

[Arun Isaac]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]


Hi,

This is likely a bug in guile-email. It shouldn't have returned the
unparsed From address. It was likely triggered by "Jorge P. de Morais
Neto <jorge+list@disroot.org>" being an invalid address. The period
character is not allowed in the name and should have been quoted like
"\"Jorge P. de Morais Neto\" <jorge+list@disroot.org>". I will
investigate and come up with some fix within 24 hours.

Meanwhile, do CC me or guile-email@systemreboot.net on anything
guile-email related. That would help me take note sooner. I found this
bug report almost by chance.

Thanks,
Arun

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

bug#45015: [mumi] 44964 cannot be displayed

[Ricardo Wurmus]

Arun Isaac <arunisaac@systemreboot.net> writes:

> This is likely a bug in guile-email. It shouldn't have returned the
> unparsed From address. It was likely triggered by "Jorge P. de Morais
> Neto <jorge+list@disroot.org>" being an invalid address. The period
> character is not allowed in the name and should have been quoted like
> "\"Jorge P. de Morais Neto\" <jorge+list@disroot.org>". I will
> investigate and come up with some fix within 24 hours.

Thank you!

> Meanwhile, do CC me or guile-email@systemreboot.net on anything
> guile-email related. That would help me take note sooner. I found this
> bug report almost by chance.

You found it just in time.  I only just put you on Cc after I became
convinced that this might be a parser failure.

-- 
Ricardo

bug#45015: [mumi] 44964 cannot be displayed

[Arun Isaac]

[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]


> For some reason “Jorge P. de Morais Neto <jorge+list@disroot.org>” is
> not split up into name and address parts but remains a single string.

I have fixed this bug in the latest guile-email master, and added
tests to prevent regression. See
https://git.systemreboot.net/guile-email/commit/?id=37e245539bc9e27db35731e7b517cdde397834e2
and
https://git.systemreboot.net/guile-email/commit/?id=907a5d678c58eff653133df441aeecd3b7025e37

I thought “Jorge P. de Morais Neto <jorge+list@disroot.org>” was an
invalid email address due to the period character, but apparently it is
supported by the obsolete addressing specification of RFC5322 (see
https://tools.ietf.org/html/rfc5322#section-4). I hadn't implemented the
obsolete parts of the specification until now.

> Mumi commit 6fd49e9341d5673b70edfb333a4e5fa0a44128d2 works around this
> problem, which I suspect might be a bug in guile-email.

guile-email should guarantee the parsed From header is an alist of the
appropriate form. So, I vote for reverting this commit, thus reducing
complexity on mumi's end. But, I understand that guile-email is not yet
doing a great job of providing these strong guarantees.

Cheers!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

bug#45015: [mumi] 44964 cannot be displayed

[Ricardo Wurmus]

Arun Isaac <arunisaac@systemreboot.net> writes:

>> For some reason “Jorge P. de Morais Neto <jorge+list@disroot.org>” is
>> not split up into name and address parts but remains a single string.
>
> I have fixed this bug in the latest guile-email master, and added
> tests to prevent regression. See
> https://git.systemreboot.net/guile-email/commit/?id=37e245539bc9e27db35731e7b517cdde397834e2
> and
> https://git.systemreboot.net/guile-email/commit/?id=907a5d678c58eff653133df441aeecd3b7025e37

Thank you!  You are always very fast and thorough; I appreciate this a lot!

>> Mumi commit 6fd49e9341d5673b70edfb333a4e5fa0a44128d2 works around this
>> problem, which I suspect might be a bug in guile-email.
>
> guile-email should guarantee the parsed From header is an alist of the
> appropriate form. So, I vote for reverting this commit, thus reducing
> complexity on mumi's end.

I agree.  I wasn’t sure how difficult it would be to fix it in
guile-email, so I added the workaround just in case it takes longer.
I’ll upgrade and revert that commit soon.

-- 
Ricardo

bug#45015: [mumi] 44964 cannot be displayed

[Arun Isaac]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]


>> I have fixed this bug in the latest guile-email master, and added
>> tests to prevent regression. See
>> https://git.systemreboot.net/guile-email/commit/?id=37e245539bc9e27db35731e7b517cdde397834e2
>> and
>> https://git.systemreboot.net/guile-email/commit/?id=907a5d678c58eff653133df441aeecd3b7025e37
>
> Thank you!  You are always very fast and thorough; I appreciate this a
> lot!

Thank you, I really appreciate the acknowledgement! :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]