* [bug#55763] [PATCH] Upgrade nyacc to 1.07.0
@ 2022-06-02 12:14 Felix Lechner
2022-06-04 16:17 ` Josselin Poiret via Guix-patches via
2022-06-07 16:22 ` bug#55763: " Ludovic Courtès
0 siblings, 2 replies; 3+ messages in thread
From: Felix Lechner @ 2022-06-02 12:14 UTC (permalink / raw)
To: 55763
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
Control: tags -1 + patch
Hi,
For my work in making PAM configurable in Guile, I rely on the foreign
function interface (FFI). The automatic generation of that interface
requires the compile-ffi script in nyacc. Unfortunately, the highest
version we ship suffers from a bug that prevents the script from
running on the pam_client.h header in linux-pam. This patch upgrades
nyacc to the version Matt Wette released after committing the fix.
The changes are further documented in the commit message.
I am new to Guix and already use the new version of linux-pam locally
(via Guix System) but I was unable to test the patch according to the
requirements and recommendations listed for this submission. [1]
This email was sent to -devel in lieu of -mentors, which does not
exist. Any guidance is much appreciated. Thanks for taking a look!
KInd regards
Felix Lechner
[1] https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.html
[-- Attachment #2: 0001-Upgrade-nyacc-to-1.07.0.patch --]
[-- Type: application/x-patch, Size: 1410 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [bug#55763] [PATCH] Upgrade nyacc to 1.07.0
2022-06-02 12:14 [bug#55763] [PATCH] Upgrade nyacc to 1.07.0 Felix Lechner
@ 2022-06-04 16:17 ` Josselin Poiret via Guix-patches via
2022-06-07 16:22 ` bug#55763: " Ludovic Courtès
1 sibling, 0 replies; 3+ messages in thread
From: Josselin Poiret via Guix-patches via @ 2022-06-04 16:17 UTC (permalink / raw)
To: Felix Lechner, 55763
Hello Felix,
Felix Lechner <felix.lechner@gmail.com> writes:
> Control: tags -1 + patch
>
> Hi,
>
> For my work in making PAM configurable in Guile, I rely on the foreign
> function interface (FFI). The automatic generation of that interface
> requires the compile-ffi script in nyacc. Unfortunately, the highest
> version we ship suffers from a bug that prevents the script from
> running on the pam_client.h header in linux-pam. This patch upgrades
> nyacc to the version Matt Wette released after committing the fix.
>
> The changes are further documented in the commit message.
>
> I am new to Guix and already use the new version of linux-pam locally
> (via Guix System) but I was unable to test the patch according to the
> requirements and recommendations listed for this submission. [1]
>
> This email was sent to -devel in lieu of -mentors, which does not
> exist. Any guidance is much appreciated. Thanks for taking a look!
>
> KInd regards
> Felix Lechner
>
> [1] https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.html
While the contents of the patch look good, you're missing the standard
ChangeLog format for the commit message, see "(standards)Change Logs".
I would recommend something along
--8<---------------cut here---------------start------------->8---
[Your message]
* gnu/packages/mes.scm (nyacc): Update to 1.07.0.
--8<---------------cut here---------------end--------------->8---
Also, I think that inline patches are preferred, even though the manual
says that MIME is fine too. The usual advice is to just use
git-send-email to send patch series, which will take care of everything
itself (you can check out a tutorial at [1]). You could send a v2
patch, or maybe a maintainer will add the necessary format themselves
and commit, whichever comes first :).
In any case, thanks for your contribution!
[1] https://git-send-email.io/
Best,
--
Josselin Poiret
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#55763: [PATCH] Upgrade nyacc to 1.07.0
2022-06-02 12:14 [bug#55763] [PATCH] Upgrade nyacc to 1.07.0 Felix Lechner
2022-06-04 16:17 ` Josselin Poiret via Guix-patches via
@ 2022-06-07 16:22 ` Ludovic Courtès
1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2022-06-07 16:22 UTC (permalink / raw)
To: Felix Lechner; +Cc: 55763-done
Hello,
Felix Lechner <felix.lechner@gmail.com> skribis:
> For my work in making PAM configurable in Guile, I rely on the foreign
> function interface (FFI). The automatic generation of that interface
> requires the compile-ffi script in nyacc. Unfortunately, the highest
> version we ship suffers from a bug that prevents the script from
> running on the pam_client.h header in linux-pam. This patch upgrades
> nyacc to the version Matt Wette released after committing the fix.
>
> The changes are further documented in the commit message.
>
> I am new to Guix and already use the new version of linux-pam locally
> (via Guix System) but I was unable to test the patch according to the
> requirements and recommendations listed for this submission. [1]
>
> This email was sent to -devel in lieu of -mentors, which does not
> exist. Any guidance is much appreciated. Thanks for taking a look!
The patch is perfect; I only adjusted the commit log so that it follows
the ChangeLog convention, as Josselin pointed out:
https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
I also check that dependents, as reported by ‘guix refresh -l nyacc’,
all build fine with the new version.
Thanks,
Ludo’.
PS: guix-mentors now exists!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-07 16:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-02 12:14 [bug#55763] [PATCH] Upgrade nyacc to 1.07.0 Felix Lechner
2022-06-04 16:17 ` Josselin Poiret via Guix-patches via
2022-06-07 16:22 ` bug#55763: " Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.