From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sIfjDMuFm2JNtAAAbAwnHQ (envelope-from ) for ; Sat, 04 Jun 2022 18:18:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 0BjEDMuFm2K1yQAAauVa8A (envelope-from ) for ; Sat, 04 Jun 2022 18:18:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D2DF81B51D for ; Sat, 4 Jun 2022 18:18:18 +0200 (CEST) Received: from localhost ([::1]:37532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nxWTg-0002Zz-R6 for larch@yhetil.org; Sat, 04 Jun 2022 12:18:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxWTS-0002Zc-PM for guix-patches@gnu.org; Sat, 04 Jun 2022 12:18:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37418) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nxWTS-0001yQ-Gc for guix-patches@gnu.org; Sat, 04 Jun 2022 12:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nxWTS-0003ai-Ca for guix-patches@gnu.org; Sat, 04 Jun 2022 12:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55763] [PATCH] Upgrade nyacc to 1.07.0 Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 04 Jun 2022 16:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55763 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Felix Lechner , 55763@debbugs.gnu.org Received: via spool by 55763-submit@debbugs.gnu.org id=B55763.165435946213778 (code B ref 55763); Sat, 04 Jun 2022 16:18:02 +0000 Received: (at 55763) by debbugs.gnu.org; 4 Jun 2022 16:17:42 +0000 Received: from localhost ([127.0.0.1]:59548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxWT8-0003a9-9Z for submit@debbugs.gnu.org; Sat, 04 Jun 2022 12:17:42 -0400 Received: from jpoiret.xyz ([206.189.101.64]:42998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxWT6-0003Zz-4Y for 55763@debbugs.gnu.org; Sat, 04 Jun 2022 12:17:41 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 3BF1A184F27; Sat, 4 Jun 2022 16:17:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1654359458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q0jP0Ei3y/hVT5Uv+W/NcR9F/OpaV3knlfRyS206rnE=; b=kiSnPhhuRxcqWMzQ0uwywcvhvlxDUfHTX2b9ciVuIxaKwh1NpszQIbxhA6HnH/SAN74c5c sVvzOGMTxOSxIOAHCtRQEFN6l+SUssiUeWzgVMJiQ2h7Qui1afBhYG+JzKg4P9wrSlZUTU iRdeGYkitsXUxWrOfddMywnJtcdOCVMk4mlMM26Nukqx53DNh0IFkq78ww6IejKrYt9E7q HVSglDsVqeSCxDbaqeOrab70NcK7MTr4DUSxh1EuO3iAE1yR8dMI+YigRf6utD/D3tE70q qCNTKOp/bi8dgoEfR+fF/5o5VjCmHcwsMTFiyvqZYqfCpq51Cf1GY4x+LJs1qQ== In-Reply-To: References: Date: Sat, 04 Jun 2022 18:17:37 +0200 Message-ID: <87leucwggu.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches From: Josselin Poiret via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654359498; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Q0jP0Ei3y/hVT5Uv+W/NcR9F/OpaV3knlfRyS206rnE=; b=tu7Ll4xyCQZf6iE8WzZcN6GjAfuXTZbhXejkoGIGB9FfvaBslBW87N7MK6nuEoSkv3CewD gLGF0FmuRfZDa0rrEC14PteAYOX3BEDKCQY5qZ8zLxWkYqDjkPME6iXp9P73DggReu6o8l rGz8o8X3J/LFjvN8hJeCOJlV7Jq3FJ6DrUR4oQDTPwfZyTHl5SOUU+7MUbKfUv2KJ9Z2IR 9NXRq1/UfIcOEvsj63fyPkvNe6lu39qiJ4vs7kQpT1Nbv/ZmFdSbBd8CFS0D6vAHSeqGV3 +46ymtrHqKGll/ldGhH+2I0eAImkF5PWrETmY7YQNR4F10n6KjaPLDnKhi8RTw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654359498; a=rsa-sha256; cv=none; b=PS74an/4awiAFRiAETQyrsuk1YBvBWMQLVjucw8KTSPm0vrep97176sqemNQAMQyqpMBBY KN6CwqC05Ckf150bizvfN57Y0d67XraObaH6Vs9OP+K3SrKR0P2E+ukrArOHcQek5Lt3Dr 8s6v0aL7qI3+EtGp/Bl+R5ZXpIDfGlkUhjx0k4F0eYozBwxwcPlg9FUJB4rd0uPXJEteAs z/IV+ayuJO9TWGnQiSuKxg7+g24td1kFrqqyiaAB0wz/uKUf892pxA9YrdaAcBmIEyP67+ PwMzkyRnHOnv7dSiksZizE2Qe3dHLoTYXhDzrlVbbbkqLZVBO7O39A7kBNLEdA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=kiSnPhhu; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.02 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=jpoiret.xyz header.s=dkim header.b=kiSnPhhu; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D2DF81B51D X-Spam-Score: -4.02 X-Migadu-Scanner: scn0.migadu.com X-TUID: qpBm4CJ78UBh Hello Felix, Felix Lechner writes: > Control: tags -1 + patch > > Hi, > > For my work in making PAM configurable in Guile, I rely on the foreign > function interface (FFI). The automatic generation of that interface > requires the compile-ffi script in nyacc. Unfortunately, the highest > version we ship suffers from a bug that prevents the script from > running on the pam_client.h header in linux-pam. This patch upgrades > nyacc to the version Matt Wette released after committing the fix. > > The changes are further documented in the commit message. > > I am new to Guix and already use the new version of linux-pam locally > (via Guix System) but I was unable to test the patch according to the > requirements and recommendations listed for this submission. [1] > > This email was sent to -devel in lieu of -mentors, which does not > exist. Any guidance is much appreciated. Thanks for taking a look! > > KInd regards > Felix Lechner > > [1] https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.html While the contents of the patch look good, you're missing the standard ChangeLog format for the commit message, see "(standards)Change Logs". I would recommend something along --8<---------------cut here---------------start------------->8--- [Your message] * gnu/packages/mes.scm (nyacc): Update to 1.07.0. --8<---------------cut here---------------end--------------->8--- Also, I think that inline patches are preferred, even though the manual says that MIME is fine too. The usual advice is to just use git-send-email to send patch series, which will take care of everything itself (you can check out a tutorial at [1]). You could send a v2 patch, or maybe a maintainer will add the necessary format themselves and commit, whichever comes first :). In any case, thanks for your contribution! [1] https://git-send-email.io/ Best, -- Josselin Poiret