all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] gnu: Add angband.  (almost working!)
@ 2016-09-13  1:36 Christopher Allan Webber
  2017-01-28 23:00 ` Kei Kebreau
  0 siblings, 1 reply; 4+ messages in thread
From: Christopher Allan Webber @ 2016-09-13  1:36 UTC (permalink / raw)
  To: guix-devel

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

At the risk of totally destroying my productivity, I thought I'd take a
short of packaging a common roguelike.  Unfortunately, it seems like
every roguelike I try to package runs into some snag.  In this case,
angband can't find ncurses.  I don't know why!

Apparently this is related:
https://lists.freebsd.org/pipermail/freebsd-ports-bugs/2014-January/271203.html
... but I don't really know enough.

Anyone who wants to help contribute to the downfall of various GuixSD
users by assisting getting roguelikes into the distribution: this is
pretty close, if we can solve that one thing! :)

 - Chris


[-- Attachment #2: 0001-gnu-Add-angband.patch --]
[-- Type: text/x-patch, Size: 2538 bytes --]

From 5a97d5dffa12a3282b57313db8aa609f27729074 Mon Sep 17 00:00:00 2001
From: Christopher Allan Webber <cwebber@dustycloud.org>
Date: Mon, 12 Sep 2016 20:28:51 -0500
Subject: [PATCH] gnu: Add angband.

* gnu/packages/games.scm (angband): New variable.
---
 gnu/packages/games.scm | 34 +++++++++++++++++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index d386e2c..08c00b9 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -10,7 +10,7 @@
 ;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2015, 2016 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2015 David Hashe <david.hashe@dhashe.com>
-;;; Copyright © 2015 Christopher Allan Webber <cwebber@dustycloud.org>
+;;; Copyright © 2015, 2106 Christopher Allan Webber <cwebber@dustycloud.org>
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2015, 2016 Alex Kost <alezost@gmail.com>
 ;;; Copyright © 2015 Paul van der Walt <paul@denknerd.org>
@@ -223,6 +223,38 @@ them, called Jean Raymond, found an old church in which to hide, not knowing
 that beneath its ruins lay buried an ancient evil.")
     (license license:gpl3+)))
 
+(define-public angband
+  (package
+    (name "angband")
+    (version "4.0.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://rephial.org/downloads/4.0/"
+                           "angband-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0lpq2kms7hp421vrasx2bkkn9w08kr581ldwik3v0hlq6h7rlxhd"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:tests? #f                                 ;no check target
+       ;; #:configure-flags '("--enable-sdl")
+       #:phases (modify-phases %standard-phases
+                  (add-after
+                      'unpack 'autogen.sh
+                    (lambda _
+                      (zero? (system* "sh" "autogen.sh"))))))) 
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)))
+    (inputs `(("ncurses" ,ncurses)))
+    (home-page "http://rephial.org/")
+    (synopsis "Dungeon exploration roguelike")
+    (description "Classic dungeon exploration roguelike.  Explore the depths
+below Angband, seeking riches, fighting monsters, and preparing to fight
+Morgoth, the Lord of Darkness.")
+    (license license:gpl2)))
+
 (define-public pingus
   (package
     (name "pingus")
-- 
2.9.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] gnu: Add angband.  (almost working!)
  2016-09-13  1:36 [PATCH] gnu: Add angband. (almost working!) Christopher Allan Webber
@ 2017-01-28 23:00 ` Kei Kebreau
  2017-02-01 21:48   ` Christopher Allan Webber
  0 siblings, 1 reply; 4+ messages in thread
From: Kei Kebreau @ 2017-01-28 23:00 UTC (permalink / raw)
  To: Christopher Allan Webber; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 3712 bytes --]

Christopher Allan Webber <cwebber@dustycloud.org> writes:

> At the risk of totally destroying my productivity, I thought I'd take a
> short of packaging a common roguelike.  Unfortunately, it seems like
> every roguelike I try to package runs into some snag.  In this case,
> angband can't find ncurses.  I don't know why!
>
> Apparently this is related:
> https://lists.freebsd.org/pipermail/freebsd-ports-bugs/2014-January/271203.html
> ... but I don't really know enough.
>
> Anyone who wants to help contribute to the downfall of various GuixSD
> users by assisting getting roguelikes into the distribution: this is
> pretty close, if we can solve that one thing! :)
>
>  - Chris
>
> From 5a97d5dffa12a3282b57313db8aa609f27729074 Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Mon, 12 Sep 2016 20:28:51 -0500
> Subject: [PATCH] gnu: Add angband.
>
> * gnu/packages/games.scm (angband): New variable.
> ---
>  gnu/packages/games.scm | 34 +++++++++++++++++++++++++++++++++-
>  1 file changed, 33 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index d386e2c..08c00b9 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -10,7 +10,7 @@
>  ;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
>  ;;; Copyright © 2015, 2016 Andreas Enge <andreas@enge.fr>
>  ;;; Copyright © 2015 David Hashe <david.hashe@dhashe.com>
> -;;; Copyright © 2015 Christopher Allan Webber <cwebber@dustycloud.org>
> +;;; Copyright © 2015, 2106 Christopher Allan Webber <cwebber@dustycloud.org>
Should be 2016, I assume. ^
>  ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
>  ;;; Copyright © 2015, 2016 Alex Kost <alezost@gmail.com>
>  ;;; Copyright © 2015 Paul van der Walt <paul@denknerd.org>
> @@ -223,6 +223,38 @@ them, called Jean Raymond, found an old church in which to hide, not knowing
>  that beneath its ruins lay buried an ancient evil.")
>      (license license:gpl3+)))
>  
> +(define-public angband
> +  (package
> +    (name "angband")
> +    (version "4.0.5")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "http://rephial.org/downloads/4.0/"
> +                           "angband-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0lpq2kms7hp421vrasx2bkkn9w08kr581ldwik3v0hlq6h7rlxhd"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f                                 ;no check target
> +       ;; #:configure-flags '("--enable-sdl")
> +       #:phases (modify-phases %standard-phases
> +                  (add-after
> +                      'unpack 'autogen.sh
> +                    (lambda _
> +                      (zero? (system* "sh" "autogen.sh"))))))) 
> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)))
> +    (inputs `(("ncurses" ,ncurses)))
> +    (home-page "http://rephial.org/")
> +    (synopsis "Dungeon exploration roguelike")
> +    (description "Classic dungeon exploration roguelike.  Explore the depths
> +below Angband, seeking riches, fighting monsters, and preparing to fight
> +Morgoth, the Lord of Darkness.")
> +    (license license:gpl2)))
> +
>  (define-public pingus
>    (package
>      (name "pingus")

I found the issue. You must substitute the instances of the string
"ncursew5-config" with "ncursesw6-config" before running autogen.sh.
This is because we only package version 6 of the ncurses library. By
making this change, I was able to build angband reproducibly. Should we
enable the SDL, X11 and GTK+ interfaces as well?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gnu: Add angband.  (almost working!)
  2017-01-28 23:00 ` Kei Kebreau
@ 2017-02-01 21:48   ` Christopher Allan Webber
  2017-02-03 16:21     ` Kei Kebreau
  0 siblings, 1 reply; 4+ messages in thread
From: Christopher Allan Webber @ 2017-02-01 21:48 UTC (permalink / raw)
  To: Kei Kebreau; +Cc: guix-devel

Kei Kebreau writes:

> Christopher Allan Webber <cwebber@dustycloud.org> writes:
>
>> At the risk of totally destroying my productivity, I thought I'd take a
>> short of packaging a common roguelike.  Unfortunately, it seems like
>> every roguelike I try to package runs into some snag.  In this case,
>> angband can't find ncurses.  I don't know why!
>>
>> Apparently this is related:
>> https://lists.freebsd.org/pipermail/freebsd-ports-bugs/2014-January/271203.html
>> ... but I don't really know enough.
>>
>> Anyone who wants to help contribute to the downfall of various GuixSD
>> users by assisting getting roguelikes into the distribution: this is
>> pretty close, if we can solve that one thing! :)
>>
>>  - Chris
>>
>> From 5a97d5dffa12a3282b57313db8aa609f27729074 Mon Sep 17 00:00:00 2001
>> From: Christopher Allan Webber <cwebber@dustycloud.org>
>> Date: Mon, 12 Sep 2016 20:28:51 -0500
>> Subject: [PATCH] gnu: Add angband.
>>
>> * gnu/packages/games.scm (angband): New variable.
>> ---
>>  gnu/packages/games.scm | 34 +++++++++++++++++++++++++++++++++-
>>  1 file changed, 33 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
>> index d386e2c..08c00b9 100644
>> --- a/gnu/packages/games.scm
>> +++ b/gnu/packages/games.scm
>> @@ -10,7 +10,7 @@
>>  ;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
>>  ;;; Copyright © 2015, 2016 Andreas Enge <andreas@enge.fr>
>>  ;;; Copyright © 2015 David Hashe <david.hashe@dhashe.com>
>> -;;; Copyright © 2015 Christopher Allan Webber <cwebber@dustycloud.org>
>> +;;; Copyright © 2015, 2106 Christopher Allan Webber <cwebber@dustycloud.org>
> Should be 2016, I assume. ^
>>  ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
>>  ;;; Copyright © 2015, 2016 Alex Kost <alezost@gmail.com>
>>  ;;; Copyright © 2015 Paul van der Walt <paul@denknerd.org>
>> @@ -223,6 +223,38 @@ them, called Jean Raymond, found an old church in which to hide, not knowing
>>  that beneath its ruins lay buried an ancient evil.")
>>      (license license:gpl3+)))
>>  
>> +(define-public angband
>> +  (package
>> +    (name "angband")
>> +    (version "4.0.5")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "http://rephial.org/downloads/4.0/"
>> +                           "angband-" version ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "0lpq2kms7hp421vrasx2bkkn9w08kr581ldwik3v0hlq6h7rlxhd"))))
>> +    (build-system gnu-build-system)
>> +    (arguments
>> +     `(#:tests? #f                                 ;no check target
>> +       ;; #:configure-flags '("--enable-sdl")
>> +       #:phases (modify-phases %standard-phases
>> +                  (add-after
>> +                      'unpack 'autogen.sh
>> +                    (lambda _
>> +                      (zero? (system* "sh" "autogen.sh"))))))) 
>> +    (native-inputs
>> +     `(("autoconf" ,autoconf)
>> +       ("automake" ,automake)))
>> +    (inputs `(("ncurses" ,ncurses)))
>> +    (home-page "http://rephial.org/")
>> +    (synopsis "Dungeon exploration roguelike")
>> +    (description "Classic dungeon exploration roguelike.  Explore the depths
>> +below Angband, seeking riches, fighting monsters, and preparing to fight
>> +Morgoth, the Lord of Darkness.")
>> +    (license license:gpl2)))
>> +
>>  (define-public pingus
>>    (package
>>      (name "pingus")
>
> I found the issue. You must substitute the instances of the string
> "ncursew5-config" with "ncursesw6-config" before running autogen.sh.
> This is because we only package version 6 of the ncurses library. By
> making this change, I was able to build angband reproducibly. Should we
> enable the SDL, X11 and GTK+ interfaces as well?

Wow nice!

I'm for enabling at least one of the visual interfaces, though I don't
think we need to enable all of them?  Perhaps they should be different
derived package versions?  WDYT?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gnu: Add angband.  (almost working!)
  2017-02-01 21:48   ` Christopher Allan Webber
@ 2017-02-03 16:21     ` Kei Kebreau
  0 siblings, 0 replies; 4+ messages in thread
From: Kei Kebreau @ 2017-02-03 16:21 UTC (permalink / raw)
  To: Christopher Allan Webber; +Cc: guix-devel

[-- Attachment #1: Type: text/plain, Size: 4346 bytes --]

Christopher Allan Webber <cwebber@dustycloud.org> writes:

> Kei Kebreau writes:
>
>> Christopher Allan Webber <cwebber@dustycloud.org> writes:
>>
>>> At the risk of totally destroying my productivity, I thought I'd take a
>>> short of packaging a common roguelike.  Unfortunately, it seems like
>>> every roguelike I try to package runs into some snag.  In this case,
>>> angband can't find ncurses.  I don't know why!
>>>
>>> Apparently this is related:
>>> https://lists.freebsd.org/pipermail/freebsd-ports-bugs/2014-January/271203.html
>>> ... but I don't really know enough.
>>>
>>> Anyone who wants to help contribute to the downfall of various GuixSD
>>> users by assisting getting roguelikes into the distribution: this is
>>> pretty close, if we can solve that one thing! :)
>>>
>>>  - Chris
>>>
>>> From 5a97d5dffa12a3282b57313db8aa609f27729074 Mon Sep 17 00:00:00 2001
>>> From: Christopher Allan Webber <cwebber@dustycloud.org>
>>> Date: Mon, 12 Sep 2016 20:28:51 -0500
>>> Subject: [PATCH] gnu: Add angband.
>>>
>>> * gnu/packages/games.scm (angband): New variable.
>>> ---
>>>  gnu/packages/games.scm | 34 +++++++++++++++++++++++++++++++++-
>>>  1 file changed, 33 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
>>> index d386e2c..08c00b9 100644
>>> --- a/gnu/packages/games.scm
>>> +++ b/gnu/packages/games.scm
>>> @@ -10,7 +10,7 @@
>>>  ;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
>>>  ;;; Copyright © 2015, 2016 Andreas Enge <andreas@enge.fr>
>>>  ;;; Copyright © 2015 David Hashe <david.hashe@dhashe.com>
>>> -;;; Copyright © 2015 Christopher Allan Webber <cwebber@dustycloud.org>
>>> +;;; Copyright © 2015, 2106 Christopher Allan Webber <cwebber@dustycloud.org>
>> Should be 2016, I assume. ^
>>>  ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
>>>  ;;; Copyright © 2015, 2016 Alex Kost <alezost@gmail.com>
>>>  ;;; Copyright © 2015 Paul van der Walt <paul@denknerd.org>
>>> @@ -223,6 +223,38 @@ them, called Jean Raymond, found an old church in which to hide, not knowing
>>>  that beneath its ruins lay buried an ancient evil.")
>>>      (license license:gpl3+)))
>>>  
>>> +(define-public angband
>>> +  (package
>>> +    (name "angband")
>>> +    (version "4.0.5")
>>> +    (source
>>> +     (origin
>>> +       (method url-fetch)
>>> +       (uri (string-append "http://rephial.org/downloads/4.0/"
>>> +                           "angband-" version ".tar.gz"))
>>> +       (sha256
>>> +        (base32
>>> +         "0lpq2kms7hp421vrasx2bkkn9w08kr581ldwik3v0hlq6h7rlxhd"))))
>>> +    (build-system gnu-build-system)
>>> +    (arguments
>>> +     `(#:tests? #f                                 ;no check target
>>> +       ;; #:configure-flags '("--enable-sdl")
>>> +       #:phases (modify-phases %standard-phases
>>> +                  (add-after
>>> +                      'unpack 'autogen.sh
>>> +                    (lambda _
>>> +                      (zero? (system* "sh" "autogen.sh"))))))) 
>>> +    (native-inputs
>>> +     `(("autoconf" ,autoconf)
>>> +       ("automake" ,automake)))
>>> +    (inputs `(("ncurses" ,ncurses)))
>>> +    (home-page "http://rephial.org/")
>>> +    (synopsis "Dungeon exploration roguelike")
>>> +    (description "Classic dungeon exploration roguelike.  Explore the depths
>>> +below Angband, seeking riches, fighting monsters, and preparing to fight
>>> +Morgoth, the Lord of Darkness.")
>>> +    (license license:gpl2)))
>>> +
>>>  (define-public pingus
>>>    (package
>>>      (name "pingus")
>>
>> I found the issue. You must substitute the instances of the string
>> "ncursew5-config" with "ncursesw6-config" before running autogen.sh.
>> This is because we only package version 6 of the ncurses library. By
>> making this change, I was able to build angband reproducibly. Should we
>> enable the SDL, X11 and GTK+ interfaces as well?
>
> Wow nice!
>
> I'm for enabling at least one of the visual interfaces, though I don't
> think we need to enable all of them?  Perhaps they should be different
> derived package versions?  WDYT?

I say we use the SDL interface if we have to go with only one. Enabling
more interfaces in derived packages shouldn't be difficult if someone
requests them. :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-02-03 16:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-13  1:36 [PATCH] gnu: Add angband. (almost working!) Christopher Allan Webber
2017-01-28 23:00 ` Kei Kebreau
2017-02-01 21:48   ` Christopher Allan Webber
2017-02-03 16:21     ` Kei Kebreau

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.