From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8H2YK1E6g2DCZAEAgWs5BA (envelope-from ) for ; Fri, 23 Apr 2021 23:21:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id CMc7J1E6g2BXJQAAB5/wlQ (envelope-from ) for ; Fri, 23 Apr 2021 21:21:21 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 75E37164AC for ; Fri, 23 Apr 2021 23:21:20 +0200 (CEST) Received: from localhost ([::1]:35802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1la3El-0006ui-Lm for larch@yhetil.org; Fri, 23 Apr 2021 17:21:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1la3EV-0006tj-6G for guix-patches@gnu.org; Fri, 23 Apr 2021 17:21:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1la3EU-0007FC-5H for guix-patches@gnu.org; Fri, 23 Apr 2021 17:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1la3EU-0000Ow-10 for guix-patches@gnu.org; Fri, 23 Apr 2021 17:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47976] [PATCH 00/10] Add Orange Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Apr 2021 21:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47976 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 47976@debbugs.gnu.org Received: via spool by 47976-submit@debbugs.gnu.org id=B47976.16192128451509 (code B ref 47976); Fri, 23 Apr 2021 21:21:01 +0000 Received: (at 47976) by debbugs.gnu.org; 23 Apr 2021 21:20:45 +0000 Received: from localhost ([127.0.0.1]:39049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la3Dx-0000O2-T3 for submit@debbugs.gnu.org; Fri, 23 Apr 2021 17:20:44 -0400 Received: from mout01.posteo.de ([185.67.36.65]:38273) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1la3Dw-0000Nq-13 for 47976@debbugs.gnu.org; Fri, 23 Apr 2021 17:20:28 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 80EBB240027 for <47976@debbugs.gnu.org>; Fri, 23 Apr 2021 23:20:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1619212822; bh=iWJnYxGryOq+sl8RayHHAcCjKNyLH97G9YFqATlNY+I=; h=From:To:Cc:Subject:Date:From; b=W4VF+cAtzog8YJlK80W5thi8ksZrP0ARMbYdlonG/d59SBEB0R6OAq2R6rETWicyv VkveyLjxwb3uSmgfNFUCfF6n7/kt2aUxjWxFAP4wIRlI3Dcu4ES8tze4gyZbdDPLd4 jU45LYeA17NtB8nD46ftdbKxXIXz68o70Jdi2fuy+imXUNYU1igLTiLXYkqpaHcyir u1maD5edLUvGrZyumwM8LNMLp3LdYWIa3u1Jgctl5Eu6bfrsbBIP72ZPTXY20R2yk7 ePVpdgKZgcr5SAArjWzmaJK4Q53PCmgME7bo111JlyU2/HS00zwESEdsoLrfAmmqaw 9lrF7IDs3QfFA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FRnJ45myhz6tmF; Fri, 23 Apr 2021 23:20:20 +0200 (CEST) References: <20210423172547.73266-1-monego@posteo.net> From: Vinicius Monego In-reply-to: Date: Fri, 23 Apr 2021 21:20:08 +0000 Message-ID: <87k0osk8af.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619212880; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=W/99t2GxHUpZkFGE7MYDDe7XAf4BofsTs186QHRN4tw=; b=QaeeHKetmWH4xgt9OJIN1a8y8UHCVgcdViOCKXd/uGw5L+Jp5xKJibfINH5yQie559vf3t h3gCmugoj/ByNVTXDvDL0R2gCgPvsjlqyYarFkET9FeULyZA1886OHB5ZAzTBAz/iT5FLc mrVriZw0ySReSfxG/7bM3Ne8FXxniaCVrjqJmOsZfQMRQ7t1UosLwv2zGiPwoF8hIYPqkw 21Owq1XNnkiCFJG4JPeUMv0YvfkOQ3ZbOQJE2g2Wc4vejG6tgj+MS5/kgxCPuz/0zwdhdN JF/cPdI5tEg7WBAXut9e8FSzLx29k3a8+AKmeOfRp2QYdTJ/IkX1RjmXjLsN3Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619212880; a=rsa-sha256; cv=none; b=ShuAU4Fu47YUlsEQOVkTR49GXtksqmLNRv7oA7rMp/HkptZgwEnZzmoGkY1XCma7KR5HOk CeI4prAmIM16URRoCiTeU78azKjttgYD/2q7FnKYXD4/xOeGwrmKeDvC/nhVUoQyNI2akJ OBd/XJUSPkKsVC3h/stVwhrCHyQGxZ6gMVnyrYKMu3t734mRqewMDHMAR/mGMsUNPo/dAJ QuKuzC8BhZj8CVaLcHwUf/ehZ4rqyKiueVDao+fIBpXtElbwf3gVmaTh7eO0iw12cFqaMz kTUHwqwyx6nlNe/vbT2ybWUYkrofSEGKhYTt0IXGfZsdxpszZl7PFaoUbvi8Vw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=W4VF+cAt; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=W4VF+cAt; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 75E37164AC X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: yak6cLi9v9kw Leo Famulari writes: > On Fri, Apr 23, 2021 at 05:25:47PM +0000, Vinicius Monego wrote: >> This patchset adds the Orange data mining / data visualization / machine learning toolkit. >> >> I had to disable tests for the orange widget base because unittest failed to load a file. But all tests for orange itself are passing. >> >> Vinicius Monego (10): >> gnu: Add python-anyqt. >> gnu: Add python-pyqtgraph. >> gnu: Add python-qasync. >> gnu: Add python-orange-canvas-core. >> gnu: Add python-orange-widget-base. >> gnu: Add python-serverfiles. >> gnu: Add python-python-louvain. >> gnu: python-pynndescent: Update to 0.5.2. >> gnu: python-opentsne: Update to 0.5.2. >> gnu: Add orange. > > Thanks! I sent some comments. > > Otherwise, the patches look good to me, based on these standard > assumptions: > > 1) You linted and built the packages > 2) The packages are using the latest upstream versions > 3) You checked that the licenses are correct Thanks for the reminder. I spotted some issues. - python-setuptools can be removed from the inputs of python-orange-canvas-core. The linter will also complain about python-docutils being propagated, but that is how it should be. - python-qasync's license is bsd-2, not bsd-3. - httpx doesn't need version substitution in orange (already commented in the other reply). Orange also states in the website that "non-code" parts are licensed under CC-BY-SA (version not specified), if that's relevant: https://orangedatamining.com/license/ All versions are up to date and all packages were built. Should I send a v2 only for the affected patches?