From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Lars-Dominik Braun <lars@6xq.net>
Cc: 45712@debbugs.gnu.org
Subject: [bug#45712] [PATCHES] Improve Python package quality
Date: Fri, 29 Jan 2021 09:26:18 -0500 [thread overview]
Message-ID: <87h7mzyg39.fsf_-_@gmail.com> (raw)
In-Reply-To: <YBLj35oSVDaPQCYo@noor.fritz.box> (Lars-Dominik Braun's message of "Thu, 28 Jan 2021 17:18:39 +0100")
Hi Lars,
Lars-Dominik Braun <lars@6xq.net> writes:
> Hi Maxim,
>
>> Doesn't that mean that the attrs requirement should be lifted from the
>> bootstrap version? As its purpose is exactly this: breaking the cyclic
>> dependency with itself.
> ah, now I see the problem, there’s a (add-installed-pythonpath inputs
> outputs) missing and so it can’t find the installed packages. Maybe
> we’re working on different branches? I applied your patch directly to
> core-updates.
>
> Cheers,
> Lars
Oh yes, sorry I had failed to mention it, this is on the
cu/farewell-to-pythonpath branch, which is the integration of
GUIX_PYTHONPATH and this work of yours. I've included your v2 patches,
with light editing: fixed the script indentation (spot via flake8), I
removed the python2 tests as Python 2 is obsolete, and removed the space
between the (procedure)[area/conditional] part of the GNU changelog
commit messages.
Another note to help with review; when sending v2 patches, make sure the
title of your mail reply mentions [PATCH v2]; this helps to spot the
later versions in email threads.
The branch is shaping up nicely; I encourage you to try it. If no major
problem is found with it, I'll merge it in core-updates soon.
Thank you,
Maxim
next prev parent reply other threads:[~2021-01-29 14:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 13:26 [bug#45712] [PATCHES] Improve Python package quality Lars-Dominik Braun
2021-01-08 11:37 ` Hartmut Goebel
2021-01-08 12:19 ` Ricardo Wurmus
2021-01-12 9:37 ` Lars-Dominik Braun
2021-01-25 19:29 ` Maxim Cournoyer
2021-01-26 8:39 ` Lars-Dominik Braun
2021-01-28 15:40 ` Maxim Cournoyer
2021-01-28 16:18 ` Lars-Dominik Braun
2021-01-29 14:26 ` Maxim Cournoyer [this message]
2021-02-01 7:20 ` Lars-Dominik Braun
2021-02-01 17:02 ` bug#45712: " Maxim Cournoyer
2021-02-07 16:59 ` [bug#45712] " Hartmut Goebel
2021-02-08 8:02 ` Lars-Dominik Braun
2021-01-25 14:43 ` Maxim Cournoyer
2021-01-25 19:42 ` Lars-Dominik Braun
2021-01-25 14:48 ` Maxim Cournoyer
2021-01-29 14:14 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7mzyg39.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=45712@debbugs.gnu.org \
--cc=lars@6xq.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.