From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iGsDBEAbFGAoTAAA0tVLHw (envelope-from ) for ; Fri, 29 Jan 2021 14:27:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id sHNzOz8bFGA6PQAAbx9fmQ (envelope-from ) for ; Fri, 29 Jan 2021 14:27:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 95A2194021E for ; Fri, 29 Jan 2021 14:27:11 +0000 (UTC) Received: from localhost ([::1]:40600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5Uju-0002wk-JI for larch@yhetil.org; Fri, 29 Jan 2021 09:27:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5Ujm-0002vh-Ri for guix-patches@gnu.org; Fri, 29 Jan 2021 09:27:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l5Ujm-0001z0-Iq for guix-patches@gnu.org; Fri, 29 Jan 2021 09:27:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l5Ujm-0004w3-F9 for guix-patches@gnu.org; Fri, 29 Jan 2021 09:27:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45712] [PATCHES] Improve Python package quality Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 29 Jan 2021 14:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45712 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Received: via spool by 45712-submit@debbugs.gnu.org id=B45712.161193039118880 (code B ref 45712); Fri, 29 Jan 2021 14:27:02 +0000 Received: (at 45712) by debbugs.gnu.org; 29 Jan 2021 14:26:31 +0000 Received: from localhost ([127.0.0.1]:51416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5UjF-0004uR-FD for submit@debbugs.gnu.org; Fri, 29 Jan 2021 09:26:31 -0500 Received: from mail-qv1-f52.google.com ([209.85.219.52]:38610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5UjB-0004u7-Fq for 45712@debbugs.gnu.org; Fri, 29 Jan 2021 09:26:27 -0500 Received: by mail-qv1-f52.google.com with SMTP id n14so4510195qvg.5 for <45712@debbugs.gnu.org>; Fri, 29 Jan 2021 06:26:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=EM2epWhnqulqoAaWSqaVSsNiE5acE3QLhNjtUGaSsas=; b=Ef1M/k7gRJBMyzdlGsEUeyANKrNzyXSFgBaSVYf8NzPoKhCtvatPP5cmODkDCCLK3o Q5EOiU9YVGmYTDgE9824qCzuiEcnOgOM392FHGtaqZ8rVgw/6pRmLywLKYRzPhazKnLp siBKgbdFnAUhgSFiZjtRSlAfyfVYxp3/VxTOwGhhVq0bnGS6Lzi/B6CM9Gb/pRt5FNyQ MDbkoeCWW7pFQBFwWCvyPs5mSolf5UyFl0DdEt0rln9kF4TiISSLjfdWcd56M7P4RfBY yggNwWx7USezZxmrgAV9bNWRCPHcwCGJ4mn9ls2spqvhBmXlQVlInR56c8Feke1CM1u2 uNsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=EM2epWhnqulqoAaWSqaVSsNiE5acE3QLhNjtUGaSsas=; b=LP821H4+gKL6EVewd3jurFZXkQmEjmthyG7zykDJWLTC2poqK9GtIcXEOCqW47djEL L8PB4s3tkOHRYF6bBq7M7Cdy9eeeKAZGx4h96a2PmYU69k/Q3btZ+hvWOSaSTbrk/pC2 eF56TBDVS4snpHHFzfhQoeY5+CJoOkPVNT9/+dkARPxSFO2n4Os8H6nb+TR4en5I7SG+ yNR+vnLxsPt3+rkvqfkhdoIscc93oT4O2pSZz8qXy4F9cpSrYMU+K0d1p3CgptNTZ11O pM68SlN7t7qIVlHscOcXhFUFtmPMl0Zi7iX1gA7S6jsr1W6zZEZmaxhypI8saWFczKbE FJXQ== X-Gm-Message-State: AOAM533NpNFUSVuQVvMDaZuUHNZf0MknQHSZyCg7huQyLIFIXGDU0cdZ dcThwB/dnmaYwMt7rPPUGYX+dIyN7RQ= X-Google-Smtp-Source: ABdhPJyWowVXWDaNpACfJaqt2TW3Ac6hXGJsmG1nrMuAxx0Ynw1hRMt4DmvjPxhS3HAC5pD9ep30Vg== X-Received: by 2002:ad4:468c:: with SMTP id bq12mr4068997qvb.11.1611930379709; Fri, 29 Jan 2021 06:26:19 -0800 (PST) Received: from hurd (dsl-148-165.b2b2c.ca. [66.158.148.165]) by smtp.gmail.com with ESMTPSA id z132sm6016684qka.131.2021.01.29.06.26.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jan 2021 06:26:19 -0800 (PST) From: Maxim Cournoyer References: <87czxs3jel.fsf_-_@gmail.com> <874kj1ysr9.fsf_-_@gmail.com> Date: Fri, 29 Jan 2021 09:26:18 -0500 In-Reply-To: (Lars-Dominik Braun's message of "Thu, 28 Jan 2021 17:18:39 +0100") Message-ID: <87h7mzyg39.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45712@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.25 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b="Ef1M/k7g"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 95A2194021E X-Spam-Score: -1.25 X-Migadu-Scanner: scn1.migadu.com X-TUID: evS+50BPKZ3O Hi Lars, Lars-Dominik Braun writes: > Hi Maxim, > >> Doesn't that mean that the attrs requirement should be lifted from the >> bootstrap version? As its purpose is exactly this: breaking the cyclic >> dependency with itself. > ah, now I see the problem, there=E2=80=99s a (add-installed-pythonpath in= puts > outputs) missing and so it can=E2=80=99t find the installed packages. May= be > we=E2=80=99re working on different branches? I applied your patch directl= y to > core-updates. > > Cheers, > Lars Oh yes, sorry I had failed to mention it, this is on the cu/farewell-to-pythonpath branch, which is the integration of GUIX_PYTHONPATH and this work of yours. I've included your v2 patches, with light editing: fixed the script indentation (spot via flake8), I removed the python2 tests as Python 2 is obsolete, and removed the space between the (procedure)[area/conditional] part of the GNU changelog commit messages. Another note to help with review; when sending v2 patches, make sure the title of your mail reply mentions [PATCH v2]; this helps to spot the later versions in email threads. The branch is shaping up nicely; I encourage you to try it. If no major problem is found with it, I'll merge it in core-updates soon. Thank you, Maxim