From: Hartmut Goebel <hartmut@goebel-consult.de>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>,
Lars-Dominik Braun <lars@6xq.net>
Cc: Ricardo Wurmus <rekado@elephly.net>, 45712@debbugs.gnu.org
Subject: [bug#45712] [PATCHES] Improve Python package quality
Date: Sun, 7 Feb 2021 17:59:02 +0100 [thread overview]
Message-ID: <6ace098f-4e4a-0f6f-ba09-f66728bdb564@goebel-consult.de> (raw)
In-Reply-To: <87czxs3jel.fsf_-_@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
Hi Maxim,
>
> Attached is a small rework of your original patch. I've made the Python
> script standalone, which should make it easier to maintain. I've also
> refactored the tests somewhat and added your copyright information.
>
> Is this OK with you?
I had discussed some change to his original patch with Lars. Can't
remember all point, just these:
+ if group not in {'console_scripts', }:
"gui_scripts"m are missing. Using a set there is uncommon, since it is a
constant value anyway.
+ # And finally try to load top level modules. This should not have any
+ # side-effects.
I'd try loading the top level module first. As this is a pre-condition
for loading the entry-points.
--
+++hartmut
| Hartmut Goebel | |
| hartmut@goebel-consult.de | www.goebel-consult.de |
[-- Attachment #2: Type: text/html, Size: 2484 bytes --]
next prev parent reply other threads:[~2021-02-07 17:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 13:26 [bug#45712] [PATCHES] Improve Python package quality Lars-Dominik Braun
2021-01-08 11:37 ` Hartmut Goebel
2021-01-08 12:19 ` Ricardo Wurmus
2021-01-12 9:37 ` Lars-Dominik Braun
2021-01-25 19:29 ` Maxim Cournoyer
2021-01-26 8:39 ` Lars-Dominik Braun
2021-01-28 15:40 ` Maxim Cournoyer
2021-01-28 16:18 ` Lars-Dominik Braun
2021-01-29 14:26 ` Maxim Cournoyer
2021-02-01 7:20 ` Lars-Dominik Braun
2021-02-01 17:02 ` bug#45712: " Maxim Cournoyer
2021-02-07 16:59 ` Hartmut Goebel [this message]
2021-02-08 8:02 ` [bug#45712] " Lars-Dominik Braun
2021-01-25 14:43 ` Maxim Cournoyer
2021-01-25 19:42 ` Lars-Dominik Braun
2021-01-25 14:48 ` Maxim Cournoyer
2021-01-29 14:14 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ace098f-4e4a-0f6f-ba09-f66728bdb564@goebel-consult.de \
--to=hartmut@goebel-consult.de \
--cc=45712@debbugs.gnu.org \
--cc=lars@6xq.net \
--cc=maxim.cournoyer@gmail.com \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.