From: "Ludovic Courtès" <ludo@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 59078@debbugs.gnu.org
Subject: [bug#59078] [PATCH] lint: Split the derivation lint checker by system.
Date: Mon, 14 Nov 2022 13:51:37 +0100 [thread overview]
Message-ID: <87h6z1puli.fsf@gnu.org> (raw)
In-Reply-To: <87bkpau4kl.fsf@cbaines.net> (Christopher Baines's message of "Sun, 13 Nov 2022 17:27:48 +0000")
Hi!
Christopher Baines <mail@cbaines.net> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
[...]
>> The ‘derivation’ checker was added for this purpose: making sure that a
>> package’s derivation can be computed for all the supported systems.
>> Previously it was easy to overlook that kind of breakage.
>>
>> I think it’s important to keep a ‘derivation’ checker that does this.
>
> What aspect of it do you think is important?
I meant that it’s important to have a single ‘derivation’ checker that
checks derivations for all the supported systems. Packagers should be
able to run ‘guix lint -c derivation PKG’ and be confident that it’s
fine for all systems.
>> Now, the memory consumption you report is unacceptable and this needs to
>> be addressed.
>>
>> Most (all?) caches are now per-session (associated with
>> <store-connection>). Since ‘guix lint’ uses a single session, those
>> caches keep growing because there’s no eviction mechanism in place.
>>
>> A hack like the one below should work around that. Could you check how
>> well it works for you?
>
> I tried in the Guix Data Service processing packages in chunks of 1000
> plus closing the store connection after each batch,
How was it implemented? Was it after the caches came into
<store-connection>?
> and that led to a heap size of 3090MiB. But this is still higher than
> 1778MiB heap usage I got just by splitting the derivation linter.
I didn’t take the time to do it, but it would be nice to see, with the
patch I gave, how ‘guix lint -c derivations’ behaves.
Thanks,
Ludo’.
next prev parent reply other threads:[~2022-11-14 23:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 13:55 [bug#59078] [PATCH] lint: Split the derivation lint checker by system Christopher Baines
2022-11-07 17:37 ` Christopher Baines
2022-11-11 21:57 ` Ludovic Courtès
2022-11-13 17:27 ` Christopher Baines
2022-11-14 12:51 ` Ludovic Courtès [this message]
2022-11-15 8:35 ` Christopher Baines
2022-11-17 17:22 ` Ludovic Courtès
2022-11-15 9:03 ` zimoun
2023-01-27 17:48 ` Simon Tournier
2023-01-31 16:33 ` Ludovic Courtès
2023-02-01 9:47 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6z1puli.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=59078@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.