all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Christopher Baines <mail@cbaines.net>, 59078@debbugs.gnu.org
Subject: [bug#59078] [PATCH] lint: Split the derivation lint checker by system.
Date: Wed, 01 Feb 2023 10:47:08 +0100	[thread overview]
Message-ID: <868rhhvhsz.fsf@gmail.com> (raw)
In-Reply-To: <87tu06u0iz.fsf@gnu.org>

Hi Ludo,

On Tue, 31 Jan 2023 at 17:33, Ludovic Courtès <ludo@gnu.org> wrote:

> In general, being able to tell which category a checker belongs to, and
> then being able to select checkers by categories sounds like a useful
> improvement to me.
>
> I don’t think it solves the problem Christopher initially reported
> though (about memory consumption of the ‘derivation’ checker.)

Indeed.  My understanding of the proposal is to split some checkers (as
derivation) and then group them to have the expected behaviour.  You
wrote [1]:

        I meant that it’s important to have a single ‘derivation’
        checker that checks derivations for all the supported systems.
        Packagers should be able to run ‘guix lint -c derivation PKG’
        and be confident that it’s fine for all systems.

and Chris answered [2]:

        I think we can still keep that by adding support for grouping
        lint checkers. So have a derivation group, instead of a single
        checker.

        Maybe that'll change the command slightly to 'guix lint -g derivation
        PKG', but I think that can be equivalent.

where I try to feed Chris’s proposal. :-)

I do not know if it is the correct level but being able to run “smaller“
checkers appears to me worth to try.

1: http://issues.guix.gnu.org/msgid/87h6z1puli.fsf@gnu.org
2: http://issues.guix.gnu.org/msgid/87leocfsnm.fsf@cbaines.net

Cheers,
simon




      reply	other threads:[~2023-02-01 10:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-06 13:55 [bug#59078] [PATCH] lint: Split the derivation lint checker by system Christopher Baines
2022-11-07 17:37 ` Christopher Baines
2022-11-11 21:57 ` Ludovic Courtès
2022-11-13 17:27   ` Christopher Baines
2022-11-14 12:51     ` Ludovic Courtès
2022-11-15  8:35       ` Christopher Baines
2022-11-17 17:22         ` Ludovic Courtès
2022-11-15  9:03       ` zimoun
2023-01-27 17:48         ` Simon Tournier
2023-01-31 16:33           ` Ludovic Courtès
2023-02-01  9:47             ` zimoun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868rhhvhsz.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=59078@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.