From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wOmbBeDQcmMBJgEAbAwnHQ (envelope-from ) for ; Tue, 15 Nov 2022 00:36:00 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id UJ56BeDQcmO/xQAAauVa8A (envelope-from ) for ; Tue, 15 Nov 2022 00:36:00 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B0FC03FB4C for ; Tue, 15 Nov 2022 00:35:59 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouilA-0005m6-Tf; Mon, 14 Nov 2022 18:21:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouifT-0004p5-QE for guix-patches@gnu.org; Mon, 14 Nov 2022 18:15:09 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouYwT-0006R0-ST for guix-patches@gnu.org; Mon, 14 Nov 2022 07:52:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ouYwT-0007X3-Nw for guix-patches@gnu.org; Mon, 14 Nov 2022 07:52:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59078] [PATCH] lint: Split the derivation lint checker by system. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 14 Nov 2022 12:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59078 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 59078@debbugs.gnu.org Received: via spool by 59078-submit@debbugs.gnu.org id=B59078.166843030928934 (code B ref 59078); Mon, 14 Nov 2022 12:52:01 +0000 Received: (at 59078) by debbugs.gnu.org; 14 Nov 2022 12:51:49 +0000 Received: from localhost ([127.0.0.1]:49103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouYwG-0007Wc-TX for submit@debbugs.gnu.org; Mon, 14 Nov 2022 07:51:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouYwE-0007WP-PA for 59078@debbugs.gnu.org; Mon, 14 Nov 2022 07:51:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouYw9-0006Pa-Eb; Mon, 14 Nov 2022 07:51:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=4382XRtYEFJmfpv8Tfpz6I76GVbBRulb0pTF2habUqI=; b=pAWgu2IktBeA8eEjJ44h YYzKzO9D4T0P7eax+Ngz925rrB4k4XiUi7mfpZhx/UmM9kRkq9/e9OLSqafwz4lp2ZKijmNN114P1 78rrsoF3ycyqRE56OAfQKH/2CvC1dOaGv1h/JqKDhEZwHSnLhV0+7KOJYyk1lxp0wPELKN8NWeEE0 O2D2C/62V2J7fPsmJ65ILyiGFkOrAGxpqhwaXEo8bTgilZZoDMAEg1MDlbNgUsHMJOzx5VUTPH2yp 8gug8ZsVQwtlXgnu9InOe8n2hfjGd0AQaWy3k07KP7oV1x0rYffeG2lGcfY/1e5kqs9lSwM30PWG/ I1vtpAijOn01Aw==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouYw9-00040V-1G; Mon, 14 Nov 2022 07:51:41 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20221106135532.5724-1-mail@cbaines.net> <87k041dui7.fsf@gnu.org> <87bkpau4kl.fsf@cbaines.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quartidi 24 Brumaire an 231 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de l'Orange X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 14 Nov 2022 13:51:37 +0100 In-Reply-To: <87bkpau4kl.fsf@cbaines.net> (Christopher Baines's message of "Sun, 13 Nov 2022 17:27:48 +0000") Message-ID: <87h6z1puli.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668468959; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4382XRtYEFJmfpv8Tfpz6I76GVbBRulb0pTF2habUqI=; b=BN5XAFzOFAyQMc8DMIs9P0h8DpxazX9zOnqJyhVqTBIgYB7D+zel8ZmbCZdJAoefrdtjLI MGCSzkmzDvfgv50UMVn0nhkemIRgwZmrsrR3eSv/nWlfTB9C3lqKQ60O7of7Oyg87N6/qy DNRqyawH5K0cX+E9TszBgpdc58b9J5RBNH8Erfo9T+ZpVVG7PqNLDVgFvWpxUozXDTWnBl SK3KMdW2PeuYK8kJQSys0KlR7xqgX22oPogWppUdRv2r8xmVkbeYGaxU94Y2L+Q8EK6/w3 KgImK/DmziNkUHtO13SWZEAeiQikOpDJEmEcKhnTbVSuDp6prJ8H37z9mOkFoA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668468959; a=rsa-sha256; cv=none; b=KRwuzkENnlwursy90IhqmPsdHZ4W1pnDqbHyGGPHt0B5V93hJdwAT/Qpt1VOPCug0BCcMQ bU3ItXCkfNGuHDCuEmcEnz50+0pifkn4SkjOYJkBJ5RhH6h2eQpAuu18IKWxew3km3wvWl orjvWeK+z6ZDu1HxeP6oVi5yx907aXGkdlST/8IFdjhys7Vdl7YK5JTUmlcssuWiETVaS4 uaZcxvwl9M7LjpMq5bHtQpxek/VV2JIM4N3Qim8ahgXiPC2Mxc+DvIyam052yRyiGYOr+Q qsBCkfyocQEfNyTBKj1vHumWcDC3pvdwI4lK7BwFRH0not39URpyAC56tz9F7w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=pAWgu2Ik; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.94 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=pAWgu2Ik; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B0FC03FB4C X-Spam-Score: -3.94 X-Migadu-Scanner: scn1.migadu.com X-TUID: mavGBAJ9QDFn Hi! Christopher Baines skribis: > Ludovic Court=C3=A8s writes: [...] >> The =E2=80=98derivation=E2=80=99 checker was added for this purpose: mak= ing sure that a >> package=E2=80=99s derivation can be computed for all the supported syste= ms. >> Previously it was easy to overlook that kind of breakage. >> >> I think it=E2=80=99s important to keep a =E2=80=98derivation=E2=80=99 ch= ecker that does this. > > What aspect of it do you think is important? I meant that it=E2=80=99s important to have a single =E2=80=98derivation=E2= =80=99 checker that checks derivations for all the supported systems. Packagers should be able to run =E2=80=98guix lint -c derivation PKG=E2=80=99 and be confident = that it=E2=80=99s fine for all systems. >> Now, the memory consumption you report is unacceptable and this needs to >> be addressed. >> >> Most (all?) caches are now per-session (associated with >> ). Since =E2=80=98guix lint=E2=80=99 uses a single se= ssion, those >> caches keep growing because there=E2=80=99s no eviction mechanism in pla= ce. >> >> A hack like the one below should work around that. Could you check how >> well it works for you? > > I tried in the Guix Data Service processing packages in chunks of 1000 > plus closing the store connection after each batch, How was it implemented? Was it after the caches came into ? > and that led to a heap size of 3090MiB. But this is still higher than > 1778MiB heap usage I got just by splitting the derivation linter. I didn=E2=80=99t take the time to do it, but it would be nice to see, with = the patch I gave, how =E2=80=98guix lint -c derivations=E2=80=99 behaves. Thanks, Ludo=E2=80=99.