all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: guix-devel@gnu.org
Subject: Re: 04/36: gnu: guix: Do not copy bootstrap-guile when cross-compiling.
Date: Sun, 26 Apr 2020 18:04:45 +0200	[thread overview]
Message-ID: <87ftcq2pya.fsf@gnu.org> (raw)
In-Reply-To: <20200424121406.14E8220D9C@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Fri, 24 Apr 2020 08:14:05 -0400 (EDT)")

Hi!

guix-commits@gnu.org skribis:

> commit f1bf6c5d7dfae3c1fc28e417c2f0940b0b010087
> Author: Jan (janneke) Nieuwenhuizen <janneke@gnu.org>
> AuthorDate: Fri Apr 24 08:54:43 2020 +0200
>
>     gnu: guix: Do not copy bootstrap-guile when cross-compiling.
>     
>     * gnu/packages/package-management.scm (guix)[arguments]: When cross-compiling,
>     skip copy-bootstrap-guile phase; needed for tests only.

[...]

> -                    (add-before 'check 'copy-bootstrap-guile
> +                    ,@(if (%current-target-system)
> +                          '()
> +                          `((add-before 'check 'copy-bootstrap-guile
>                        (lambda* (#:key system inputs #:allow-other-keys)

Perhaps it would be clearer by avoiding the unquote-splicing dance:

  (lambda* (#:key system target inputs #:allow-other-keys)
    (unless target
      …)
    #t)

Otherwise LGTM!

Ludo’.

       reply	other threads:[~2020-04-26 16:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200424121351.29896.37425@vcs0.savannah.gnu.org>
     [not found] ` <20200424121406.14E8220D9C@vcs0.savannah.gnu.org>
2020-04-26 16:04   ` Ludovic Courtès [this message]
2020-04-26 19:09     ` 04/36: gnu: guix: Do not copy bootstrap-guile when cross-compiling Jan Nieuwenhuizen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftcq2pya.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.