From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@gnu.org>
Subject: Re: 04/36: gnu: guix: Do not copy bootstrap-guile when
 cross-compiling.
Date: Sun, 26 Apr 2020 18:04:45 +0200
Message-ID: <87ftcq2pya.fsf@gnu.org>
References: <20200424121351.29896.37425@vcs0.savannah.gnu.org>
 <20200424121406.14E8220D9C@vcs0.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:41486)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@gnu.org>) id 1jSjlw-0000w0-Ea
 for guix-devel@gnu.org; Sun, 26 Apr 2020 12:04:48 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:45260)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@gnu.org>) id 1jSjlw-0007JX-6s
 for guix-devel@gnu.org; Sun, 26 Apr 2020 12:04:48 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=49144 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@gnu.org>) id 1jSjlv-0008VR-9e
 for guix-devel@gnu.org; Sun, 26 Apr 2020 12:04:47 -0400
In-Reply-To: <20200424121406.14E8220D9C@vcs0.savannah.gnu.org>
 (guix-commits@gnu.org's message of "Fri, 24 Apr 2020 08:14:05 -0400
 (EDT)")
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org
Sender: "Guix-devel"
 <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
To: guix-devel@gnu.org

Hi!

guix-commits@gnu.org skribis:

> commit f1bf6c5d7dfae3c1fc28e417c2f0940b0b010087
> Author: Jan (janneke) Nieuwenhuizen <janneke@gnu.org>
> AuthorDate: Fri Apr 24 08:54:43 2020 +0200
>
>     gnu: guix: Do not copy bootstrap-guile when cross-compiling.
>=20=20=20=20=20
>     * gnu/packages/package-management.scm (guix)[arguments]: When cross-c=
ompiling,
>     skip copy-bootstrap-guile phase; needed for tests only.

[...]

> -                    (add-before 'check 'copy-bootstrap-guile
> +                    ,@(if (%current-target-system)
> +                          '()
> +                          `((add-before 'check 'copy-bootstrap-guile
>                        (lambda* (#:key system inputs #:allow-other-keys)

Perhaps it would be clearer by avoiding the unquote-splicing dance:

  (lambda* (#:key system target inputs #:allow-other-keys)
    (unless target
      =E2=80=A6)
    #t)

Otherwise LGTM!

Ludo=E2=80=99.