all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jan Nieuwenhuizen <janneke@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: 04/36: gnu: guix: Do not copy bootstrap-guile when cross-compiling.
Date: Sun, 26 Apr 2020 21:09:08 +0200	[thread overview]
Message-ID: <87d07um5d7.fsf@gnu.org> (raw)
In-Reply-To: <87ftcq2pya.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sun, 26 Apr 2020 18:04:45 +0200")

Ludovic Courtès writes:

>>     gnu: guix: Do not copy bootstrap-guile when cross-compiling.
>>     
>>     * gnu/packages/package-management.scm (guix)[arguments]: When cross-compiling,
>>     skip copy-bootstrap-guile phase; needed for tests only.
...
>> -                    (add-before 'check 'copy-bootstrap-guile
>> +                    ,@(if (%current-target-system)
>> +                          '()
>> +                          `((add-before 'check 'copy-bootstrap-guile
>>                        (lambda* (#:key system inputs #:allow-other-keys)
>
> Perhaps it would be clearer by avoiding the unquote-splicing dance:
>
>   (lambda* (#:key system target inputs #:allow-other-keys)
>     (unless target
>       …)
>     #t)

Ah, yes.  No need to be careful not to trigger a rebuild.

> Otherwise LGTM!

Thanks, pushed to core-updates.
janneke

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

      reply	other threads:[~2020-04-26 19:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200424121351.29896.37425@vcs0.savannah.gnu.org>
     [not found] ` <20200424121406.14E8220D9C@vcs0.savannah.gnu.org>
2020-04-26 16:04   ` 04/36: gnu: guix: Do not copy bootstrap-guile when cross-compiling Ludovic Courtès
2020-04-26 19:09     ` Jan Nieuwenhuizen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d07um5d7.fsf@gnu.org \
    --to=janneke@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.