From: Alex Kost <alezost@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/3] gnu: Add llfuse.
Date: Sun, 30 Aug 2015 22:57:44 +0300 [thread overview]
Message-ID: <87d1y48s7b.fsf@gmail.com> (raw)
In-Reply-To: <a10ded9f0f7b07e614369b2b6027c439e11eecd9.1440609350.git.leo@famulari.name> (Leo Famulari's message of "Wed, 26 Aug 2015 13:16:25 -0400")
Leo Famulari (2015-08-26 20:16 +0300) wrote:
> +(define-public llfuse
> + (package
> + (name "llfuse")
> + (version "0.40")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://bitbucket.org/nikratio/python-llfuse/downloads/"
> + "llfuse-" version ".tar.bz2"))
> + (sha256
> + (base32 "0mx87n6j2g63mgiimjqn0gj6jgqfdkc04xkxc56r1azjlqji32zf"))))
> + (build-system python-build-system)
> + (inputs `(("fuse" ,fuse)
> + ("attr" ,attr)))
> + (native-inputs `(("pkg-config" ,pkg-config)))
> + (synopsis "Python bindings for FUSE")
> + (description "Python-LLFUSE is a set of Python bindings for the low level
> +FUSE API. It requires at least FUSE 2.8.0 and supports both Python 2.x and
> +3.x.")
IMHO mentioning a version of fuse is not needed. And IIUC this package
provides a python3 library, so I would also remove "supports both …".
> + (home-page "https://bitbucket.org/nikratio/python-llfuse/")
> + (license lgpl2.0)))
It should be 'lgpl2.0+' as the LICENSE file says "or (at your option)
any later version".
Also I think it is better to put this package in "python.scm" as it just
contains some general python library. But I'm not an expert here, so
better wait for comments of other people.
But I would name it 'python-llfuse' and would also add 'python2-llfuse'
package (bug again: I didn't make a single python package).
--
Alex
next prev parent reply other threads:[~2015-08-30 19:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 17:16 [PATCH 0/3] Add Attic backup program Leo Famulari
2015-08-26 17:16 ` [PATCH 1/3] gnu: Add llfuse Leo Famulari
2015-08-30 19:57 ` Alex Kost [this message]
2015-08-31 11:52 ` Ludovic Courtès
2015-09-01 21:04 ` Leo Famulari
2015-08-26 17:16 ` [PATCH 2/3] gnu: Add python-msgpack Leo Famulari
2015-08-30 19:57 ` Alex Kost
2015-08-31 11:55 ` Ludovic Courtès
2015-08-26 17:16 ` [PATCH 3/3] gnu: Add Attic Leo Famulari
2015-08-30 19:58 ` Alex Kost
2015-09-01 21:06 ` Leo Famulari
2015-08-30 20:05 ` [PATCH 0/3] Add Attic backup program Alex Kost
2015-08-31 3:52 ` Leo Famulari
2015-08-31 11:57 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1y48s7b.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.