From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH 1/3] gnu: Add llfuse.
Date: Sun, 30 Aug 2015 22:57:44 +0300
Message-ID: <87d1y48s7b.fsf@gmail.com>
References: <cover.1440609350.git.leo@famulari.name>
	<a10ded9f0f7b07e614369b2b6027c439e11eecd9.1440609350.git.leo@famulari.name>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44158)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZW8jY-0007Kb-Qg
	for guix-devel@gnu.org; Sun, 30 Aug 2015 15:57:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZW8jV-00011N-Ig
	for guix-devel@gnu.org; Sun, 30 Aug 2015 15:57:44 -0400
Received: from mail-la0-x22f.google.com ([2a00:1450:4010:c03::22f]:33689)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1ZW8jV-00011I-As
	for guix-devel@gnu.org; Sun, 30 Aug 2015 15:57:41 -0400
Received: by laboe4 with SMTP id oe4so33512425lab.0
	for <guix-devel@gnu.org>; Sun, 30 Aug 2015 12:57:40 -0700 (PDT)
In-Reply-To: <a10ded9f0f7b07e614369b2b6027c439e11eecd9.1440609350.git.leo@famulari.name>
	(Leo Famulari's message of "Wed, 26 Aug 2015 13:16:25 -0400")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

Leo Famulari (2015-08-26 20:16 +0300) wrote:

> +(define-public llfuse
> +  (package
> +   (name "llfuse")
> +   (version "0.40")
> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append
> +                  "https://bitbucket.org/nikratio/python-llfuse/download=
s/"
> +                  "llfuse-" version ".tar.bz2"))
> +            (sha256
> +             (base32 "0mx87n6j2g63mgiimjqn0gj6jgqfdkc04xkxc56r1azjlqji32=
zf"))))
> +   (build-system python-build-system)
> +   (inputs `(("fuse" ,fuse)
> +             ("attr" ,attr)))
> +   (native-inputs `(("pkg-config" ,pkg-config)))
> +   (synopsis "Python bindings for FUSE")
> +   (description "Python-LLFUSE is a set of Python bindings for the low l=
evel
> +FUSE API.  It requires at least FUSE 2.8.0 and supports both Python 2.x =
and
> +3.x.")

IMHO mentioning a version of fuse is not needed.  And IIUC this package
provides a python3 library, so I would also remove "supports both =E2=80=A6=
".

> +   (home-page "https://bitbucket.org/nikratio/python-llfuse/")
> +   (license lgpl2.0)))

It should be 'lgpl2.0+' as the LICENSE file says "or (at your option)
any later version".

Also I think it is better to put this package in "python.scm" as it just
contains some general python library.  But I'm not an expert here, so
better wait for comments of other people.

But I would name it 'python-llfuse' and would also add 'python2-llfuse'
package (bug again: I didn't make a single python package).

--=20
Alex