From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Nieuwenhuizen <janneke@gnu.org>
Subject: Re: 04/36: gnu: guix: Do not copy bootstrap-guile when
 cross-compiling.
Date: Sun, 26 Apr 2020 21:09:08 +0200
Message-ID: <87d07um5d7.fsf@gnu.org>
References: <20200424121351.29896.37425@vcs0.savannah.gnu.org>
 <20200424121406.14E8220D9C@vcs0.savannah.gnu.org>
 <87ftcq2pya.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
Received: from eggs.gnu.org ([2001:470:142:3::10]:45382)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <janneke@gnu.org>) id 1jSmeO-0001iT-Ty
 for guix-devel@gnu.org; Sun, 26 Apr 2020 15:09:13 -0400
In-Reply-To: <87ftcq2pya.fsf@gnu.org> ("Ludovic
 \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
 \=\?utf-8\?Q\?s\?\= message of "Sun, 26 Apr 2020 18:04:45 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org
Sender: "Guix-devel"
 <guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Ludovic Court=C3=A8s writes:

>>     gnu: guix: Do not copy bootstrap-guile when cross-compiling.
>>=20=20=20=20=20
>>     * gnu/packages/package-management.scm (guix)[arguments]: When cross-=
compiling,
>>     skip copy-bootstrap-guile phase; needed for tests only.
...
>> -                    (add-before 'check 'copy-bootstrap-guile
>> +                    ,@(if (%current-target-system)
>> +                          '()
>> +                          `((add-before 'check 'copy-bootstrap-guile
>>                        (lambda* (#:key system inputs #:allow-other-keys)
>
> Perhaps it would be clearer by avoiding the unquote-splicing dance:
>
>   (lambda* (#:key system target inputs #:allow-other-keys)
>     (unless target
>       =E2=80=A6)
>     #t)

Ah, yes.  No need to be careful not to trigger a rebuild.

> Otherwise LGTM!

Thanks, pushed to core-updates.
janneke

--=20
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com