From: Simon Tournier <zimon.toutoune@gmail.com>
To: "Maxim Cournoyer" <maxim.cournoyer@gmail.com>,
"Clément Lassieur" <clement@lassieur.org>
Cc: 66618@debbugs.gnu.org
Subject: [bug#66618] [PATCH] etc: gitconfig: Remove the default email address to avoid mistakes.
Date: Fri, 20 Oct 2023 16:06:59 +0200 [thread overview]
Message-ID: <87cyx9mlq4.fsf@gmail.com> (raw)
In-Reply-To: <87zg0em529.fsf@gmail.com>
Hi Maxim,
On Thu, 19 Oct 2023 at 21:54, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
> One could argue it's also a misleading documentation. It should say if
> a 'to' address is not specified *or* configured.
Well, personally I prefer: « Explicit is better than implicit. » and
« Errors should never pass silently. Unless explicitly silenced. ».
Here, the default
[sendemail]
to = guix-patches@gnu.org
makes something implicit – which is not necessary bad – but it hides
potential errors – which is not good.
IIUC, Clément use-case is the following:
git send-email --reply-to=12345@debbugs.gnu.org v2-0001-blabla.patch
which is an incorrect use of git-send-email.
Because of the default value ’sendemail.to’ from .git/config, the patch
v2-0001-blabla.patch is sent to guix-patches@gnu.org. At best, Clément
spots that and merges the new created issue with #12345. At worse, it
falls into the crack. In all cases, it is burden.
Without the default value, the mistake is directly pointed out;
git-send-email asks the value for To: since no one is provided.
With the default value, it does not teach how to correctly use
git-send-email and worse it hides the incorrect usage.
> What would you have
> typed interactively if prompted; guix-patches@gnu.org? :-)
Yes, but it teaches me that I must provide the To: field.
Well, I do not see which difficulty the default value solves. However,
I see which difficulty it introduces. :-)
> OK! I'll leave this opened for a bit longer to allow for others to tip
> in, after which I'll do so.
Somehow, I think Clément’s suggestion seems more POLA. But I do not
mind much since I always use ’--to=’. ;-)
Cheers,
simon
next prev parent reply other threads:[~2023-10-20 15:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 22:23 [bug#66618] [PATCH] etc: gitconfig: Remove the default email address to avoid mistakes Clément Lassieur
2023-10-19 1:34 ` Maxim Cournoyer
2023-10-19 9:46 ` Clément Lassieur
2023-10-19 1:36 ` Maxim Cournoyer
2023-10-19 9:37 ` Clément Lassieur
2023-10-20 1:54 ` Maxim Cournoyer
2023-10-20 8:42 ` Clément Lassieur
2023-10-20 14:06 ` Simon Tournier [this message]
2023-10-20 15:44 ` Maxim Cournoyer
2023-10-22 20:55 ` Clément Lassieur
2023-10-23 0:30 ` Maxim Cournoyer
2023-10-23 9:57 ` Simon Tournier
2023-10-23 14:17 ` Maxim Cournoyer
2023-10-25 20:11 ` Clément Lassieur
2023-10-26 8:31 ` Simon Tournier
2023-10-26 10:38 ` bug#66618: " Clément Lassieur
2023-10-23 9:49 ` [bug#66618] " Simon Tournier
2023-10-23 14:28 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyx9mlq4.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=66618@debbugs.gnu.org \
--cc=clement@lassieur.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.