all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: 66618@debbugs.gnu.org, "Clément Lassieur" <clement@lassieur.org>
Subject: [bug#66618] [PATCH] etc: gitconfig: Remove the default email address to avoid mistakes.
Date: Fri, 20 Oct 2023 11:44:39 -0400	[thread overview]
Message-ID: <87y1fxguxk.fsf@gmail.com> (raw)
In-Reply-To: <87cyx9mlq4.fsf@gmail.com> (Simon Tournier's message of "Fri, 20 Oct 2023 16:06:59 +0200")

Hi Simon,

Simon Tournier <zimon.toutoune@gmail.com> writes:

> Hi Maxim,
>
> On Thu, 19 Oct 2023 at 21:54, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
>
>> One could argue it's also a misleading documentation.  It should say if
>> a 'to' address is not specified *or* configured.  
>
> Well, personally I prefer: « Explicit is better than implicit. » and
> « Errors should never pass silently.  Unless explicitly silenced. ».
>
> Here, the default
>
>      [sendemail]
>             to = guix-patches@gnu.org
>
> makes something implicit – which is not necessary bad – but it hides
> potential errors – which is not good.

But that's true for any automation of git.  If we follow that logic we
can remove the other git configurations because they may be surprising,
and the send-email hook that notifies people, because that can again be
surprising.

Obviously, I'd rather not go that slope.  The small cost in surprise is
offset by removing manual work for myself and I'd expect/hope other
committers.  Does that make sense?

-- 
Thanks,
Maxim




  reply	other threads:[~2023-10-20 15:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-18 22:23 [bug#66618] [PATCH] etc: gitconfig: Remove the default email address to avoid mistakes Clément Lassieur
2023-10-19  1:34 ` Maxim Cournoyer
2023-10-19  9:46   ` Clément Lassieur
2023-10-19  1:36 ` Maxim Cournoyer
2023-10-19  9:37   ` Clément Lassieur
2023-10-20  1:54     ` Maxim Cournoyer
2023-10-20  8:42       ` Clément Lassieur
2023-10-20 14:06       ` Simon Tournier
2023-10-20 15:44         ` Maxim Cournoyer [this message]
2023-10-22 20:55           ` Clément Lassieur
2023-10-23  0:30             ` Maxim Cournoyer
2023-10-23  9:57               ` Simon Tournier
2023-10-23 14:17                 ` Maxim Cournoyer
2023-10-25 20:11               ` Clément Lassieur
2023-10-26  8:31                 ` Simon Tournier
2023-10-26 10:38                   ` bug#66618: " Clément Lassieur
2023-10-23  9:49           ` [bug#66618] " Simon Tournier
2023-10-23 14:28             ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1fxguxk.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=66618@debbugs.gnu.org \
    --cc=clement@lassieur.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.