From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 6BM+EV2cMmWgNQEAG6o9tA:P1 (envelope-from ) for ; Fri, 20 Oct 2023 17:27:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6BM+EV2cMmWgNQEAG6o9tA (envelope-from ) for ; Fri, 20 Oct 2023 17:27:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03B8257D50 for ; Fri, 20 Oct 2023 17:27:25 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Y7U04sog; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697815645; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=VBaKsUWLa8k9oK34L49i+zDh+Hzu326ZPmyPRqMKXzg=; b=pdSeuLz09lw27BefEIskxuUlKK7TesBmBYAFGGhItJ1el+tGc8RgMFAL7tzJqliEAs1ino zmrh3TNk/37emRVD5xL68s+veEDdFQZ5coSMD4gS11RI35478B2pOshNhZd0GXSCe2//jS fyyRuNpPwahdG38T6THlFnu7qmN5ha/pouwmAMgFZ+C9PujUJjOAPUAm1pqGoaKaMAjmR8 KN/E8p6oRTcEVMP1nt6Ag1eRhvpqFTTo3vMJyi0gpvFGXDRjQYtGqsYoxZi6P6uIMNFS3k UrcCyAXd7RXTdowRVuHoKSoQ+yKvXvY7ui64chKr2+22t6cgCy6uZgK4DKtIyA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697815645; a=rsa-sha256; cv=none; b=scwHF/TAFsglhfXxfzsRuQtidIyac14mas5JjgUTzNOpAcwJPWHPulzoZwwLG1HFOq+9xj Ak5q6aZZXAbR+6q1bP7PYc8rDZThkgQjJGTgHvciGyMgm0Czj+boN9+B5i/ij82PeK39D0 zGgJcZQvuehrojc3SaFBvqJ56au+ElIM+KQ3GXzE22kHBfahe8Ats8HEBKIaWe9AClyVEV i+ScvQZtE/sTpHs5+3pACgD4QM8Jahe00NHVA4ciziyCA4JH2bH+wtpBvWsMDH8QtSluCf de3HjbVtlpQ74DTf9Imj8WL1Hc2nQHK6puukqqm/KoGVtu0Vc/TB3l6dAHBQtg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=Y7U04sog; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtrOb-0003qV-J3; Fri, 20 Oct 2023 11:26:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtrOZ-0003e3-4k for guix-patches@gnu.org; Fri, 20 Oct 2023 11:26:39 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtrOW-0006qb-4h for guix-patches@gnu.org; Fri, 20 Oct 2023 11:26:37 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qtrOx-0000Qz-Aj for guix-patches@gnu.org; Fri, 20 Oct 2023 11:27:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66618] [PATCH] etc: gitconfig: Remove the default email address to avoid mistakes. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Oct 2023 15:27:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66618 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: Maxim Cournoyer , =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 66618@debbugs.gnu.org Received: via spool by 66618-submit@debbugs.gnu.org id=B66618.16978155821597 (code B ref 66618); Fri, 20 Oct 2023 15:27:03 +0000 Received: (at 66618) by debbugs.gnu.org; 20 Oct 2023 15:26:22 +0000 Received: from localhost ([127.0.0.1]:41204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtrOI-0000Pg-6I for submit@debbugs.gnu.org; Fri, 20 Oct 2023 11:26:22 -0400 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]:38228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtrOD-0000Oy-O9 for 66618@debbugs.gnu.org; Fri, 20 Oct 2023 11:26:18 -0400 Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2c51774da07so3144591fa.1 for <66618@debbugs.gnu.org>; Fri, 20 Oct 2023 08:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697815544; x=1698420344; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=VBaKsUWLa8k9oK34L49i+zDh+Hzu326ZPmyPRqMKXzg=; b=Y7U04sogClIeaOguzNHhk0rSomHYdGpkwG4WsaKZxYKWjBO1d+cCBLDbmehhagj11l gf7DA9qtQwUOcX5QplOFT4BqU9h70k6PiT74LTtk6SeZGPGRHum1mcPyO3XPi1hlsXEx jR3lvBdJOCn74aeJHaeUn/bTSBOH5gHiU0/JmjOS9kaJNcz8dRH3MjAghbPJ6jq24WSR aunX0/PFVkun9/VQv2cYjnRPHqOMJ1APSW5ogxrHbfbAtg15G5uEe6AiGE/RCJHSGTG2 nXJ5t4WtSklhKFujuREPqVTTgQwYmPXr6OqZxDaz7cG9qJD8+f7UzEq0QFyZLnCa12n0 qiPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697815544; x=1698420344; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VBaKsUWLa8k9oK34L49i+zDh+Hzu326ZPmyPRqMKXzg=; b=ZlckGipUl7ez6oEk/pHvIdMWY5dFc+hq65h7C4O/hN+hhX8yXKf5tQTgIHgu8IuUIy DpRAnCqcJGB5W6BQUjqJ/HWzTCIykw6CvAfsxdH9b2jbRxhOlO292X7VNvd2itOo29TJ LOxSPP5q27qAP8qJhHZDlM5fXIkJlHw1akKrgZUrahZZiA5FqxTLySj7iKoKpY9sZtuQ hNl9uxC7egUAaFbL5U96AXHMX58VdLFIrmoI1736dEzgvlJXQRMFXFPc11KIreFgtu2F roDM60bNXKPXJb5doBS7M+GgfeHTbCXxs34Z7weHJF8K2AFUsMgHZwsQr7gJNZSDT5ve wmqA== X-Gm-Message-State: AOJu0YySWFKaWJjAF6yVXHYUXdUKUSkPOZ18O9y02iuMvB96d/rzJaxb rhlbr9YYgyV7Wi8s8wzK19rtWSNgT9M= X-Google-Smtp-Source: AGHT+IFi5/fooGAX/GXsb2be6Jil5ee1SqEmnxXri0Cksiq1gNEeJ7eac4AT36ye6FodGuyftdEm1w== X-Received: by 2002:a2e:a489:0:b0:2c5:2d06:cade with SMTP id h9-20020a2ea489000000b002c52d06cademr1606275lji.2.1697815544281; Fri, 20 Oct 2023 08:25:44 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id v3-20020a05600c428300b003fee8793911sm2342061wmc.44.2023.10.20.08.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 08:25:43 -0700 (PDT) From: Simon Tournier In-Reply-To: <87zg0em529.fsf@gmail.com> References: <87pm1bqtp1.fsf@gmail.com> <87zg0em529.fsf@gmail.com> Date: Fri, 20 Oct 2023 16:06:59 +0200 Message-ID: <87cyx9mlq4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: 2.88 X-Migadu-Queue-Id: 03B8257D50 X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: 2.88 X-TUID: DD6Fy/ZYyhJL Hi Maxim, On Thu, 19 Oct 2023 at 21:54, Maxim Cournoyer w= rote: > One could argue it's also a misleading documentation. It should say if > a 'to' address is not specified *or* configured.=20=20 Well, personally I prefer: =C2=AB Explicit is better than implicit. =C2=BB = and =C2=AB=C2=A0Errors should never pass silently. Unless explicitly silenced.= =C2=BB. Here, the default [sendemail] to =3D guix-patches@gnu.org makes something implicit =E2=80=93 which is not necessary bad =E2=80=93 but= it hides potential errors =E2=80=93 which is not good. IIUC, Cl=C3=A9ment use-case is the following: git send-email --reply-to=3D12345@debbugs.gnu.org v2-0001-blabla.patch which is an incorrect use of git-send-email. Because of the default value =E2=80=99sendemail.to=E2=80=99 from .git/confi= g, the patch v2-0001-blabla.patch is sent to guix-patches@gnu.org. At best, Cl=C3=A9ment spots that and merges the new created issue with #12345. At worse, it falls into the crack. In all cases, it is burden. Without the default value, the mistake is directly pointed out; git-send-email asks the value for To: since no one is provided. With the default value, it does not teach how to correctly use git-send-email and worse it hides the incorrect usage. > What would you have > typed interactively if prompted; guix-patches@gnu.org? :-) Yes, but it teaches me that I must provide the To: field. Well, I do not see which difficulty the default value solves. However, I see which difficulty it introduces. :-) > OK! I'll leave this opened for a bit longer to allow for others to tip > in, after which I'll do so. Somehow, I think Cl=C3=A9ment=E2=80=99s suggestion seems more POLA. But I = do not mind much since I always use =E2=80=99--to=3D=E2=80=99. ;-) Cheers, simon