From: Raghav Gururajan <raghavgururajan@disroot.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 38904-done@debbugs.gnu.org
Subject: [bug#38904] gnu: Add gnome-color-manager.
Date: Thu, 09 Jan 2020 12:31:40 -0500 [thread overview]
Message-ID: <87c4d0ef5ac06fda24803cf55a20318ab7667956.camel@disroot.org> (raw)
In-Reply-To: <20200109180236.716b9974@scratchpost.org>
[-- Attachment #1: Type: text/plain, Size: 1295 bytes --]
Hi Danny!
> To find out, I've removed it from the inputs and it built just fine
> and
> gcm-viewer also started up fine. What was the reason that you added
> it?
The upstream mentioned it as a required dependency. Please view
https://gitlab.gnome.org/GNOME/gnome-build-meta/blob/master/elements/core/gnome-color-manager.bst
.
> > Would it be okay if I leave things as it is for now?
>
> You are free to leave it as is on your computer. When merging it to
> guix master there have to be some standards--otherwise master would
> be
> perpetually broken.
I understand :-)
> In this specific case, some other packages in (gnu packages gnome)
> also have
> adwaita-icon-theme as input. Even when there is that input that is
> unused it
> will not cause problems (however, it will also not do what you wanted
> it to do--whatever that is). Also, nothing depends on gnome-color-
> manager.
> Therefore, applied to guix master as commit
> 29ae18db0578bbdbc0119703f7412fe91927e80e.
Thank you!
> But really, having one specific theme (which is by definition a user-
> selectable
> thing) as an input is weird. Let's fix that everywhere eventually.
IIRC, gnome uses adwaita icon theme as default. I'll try look into what
can be done.
Regards,
RG.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-01-09 17:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 19:12 [bug#38904] gnu: Add gnome-color-manager Raghav Gururajan
2020-01-05 10:19 ` Danny Milosavljevic
2020-01-06 5:53 ` Raghav Gururajan
2020-01-08 14:50 ` [bug#38904] v3 Raghav Gururajan
2020-01-09 15:03 ` [bug#38904] gnu: Add gnome-color-manager Danny Milosavljevic
2020-01-09 15:26 ` Raghav Gururajan
2020-01-09 17:02 ` bug#38904: " Danny Milosavljevic
2020-01-09 17:31 ` Raghav Gururajan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87c4d0ef5ac06fda24803cf55a20318ab7667956.camel@disroot.org \
--to=raghavgururajan@disroot.org \
--cc=38904-done@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.