From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:54054) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipbgD-0008Mt-9D for guix-patches@gnu.org; Thu, 09 Jan 2020 12:33:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipbgA-0002xE-Or for guix-patches@gnu.org; Thu, 09 Jan 2020 12:33:08 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47051) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ipbg6-0002u4-Vi for guix-patches@gnu.org; Thu, 09 Jan 2020 12:33:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ipbg6-0003XR-U6 for guix-patches@gnu.org; Thu, 09 Jan 2020 12:33:02 -0500 Subject: [bug#38904] gnu: Add gnome-color-manager. Resent-Message-ID: Message-ID: <87c4d0ef5ac06fda24803cf55a20318ab7667956.camel@disroot.org> From: Raghav Gururajan In-Reply-To: <20200109180236.716b9974@scratchpost.org> References: <66fa4e1fc22ad1843d8996e9d687d0a0f18c2262.camel@disroot.org> <20200105111929.3a09f65c@scratchpost.org> <20200109160313.7adaf490@scratchpost.org> <20200109180236.716b9974@scratchpost.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-JFZC1w1yDFGWGgHAary2" Date: Thu, 09 Jan 2020 12:31:40 -0500 Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 38904-done@debbugs.gnu.org --=-JFZC1w1yDFGWGgHAary2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Danny! > To find out, I've removed it from the inputs and it built just fine > and > gcm-viewer also started up fine. What was the reason that you added > it? The upstream mentioned it as a required dependency. Please view=20 https://gitlab.gnome.org/GNOME/gnome-build-meta/blob/master/elements/core/g= nome-color-manager.bst . > > Would it be okay if I leave things as it is for now? >=20 > You are free to leave it as is on your computer. When merging it to > guix master there have to be some standards--otherwise master would > be > perpetually broken. I understand :-) > In this specific case, some other packages in (gnu packages gnome) > also have > adwaita-icon-theme as input. Even when there is that input that is > unused it > will not cause problems (however, it will also not do what you wanted > it to do--whatever that is). Also, nothing depends on gnome-color- > manager. > Therefore, applied to guix master as commit > 29ae18db0578bbdbc0119703f7412fe91927e80e. Thank you! > But really, having one specific theme (which is by definition a user- > selectable > thing) as an input is weird. Let's fix that everywhere eventually. IIRC, gnome uses adwaita icon theme as default. I'll try look into what can be done. Regards, RG. --=-JFZC1w1yDFGWGgHAary2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEamFiplxUWgy2NgJiorDiYAVcMdsFAl4XY3wACgkQorDiYAVc MdskVQgAlMkCakDUhvpPN1JR7uQa0zLLGDGMe3wisJ0xQPcTSPZDtEJAMK72Ofq3 PWvVxMiuE+dXGHKohKggzkydOREoDasVYlKfTkekx+l9TWVYFFln2HtJ38HU17Nk xMcyyvrhVGP/pkfXKcy/zaSUTwOrZUCco+fy/J54DbQSfWZVgNRXUGye8mHtpuHC fQspGVciB1UPt84xiMGPEGv9PLViQlKgACoCETiZXmQMSOKswR2mllDfMcWp88HP 5FVtVDN+JXdlFxa6Ia7rR9uCFjsUw6KAV5Cne/p9yjrQTYt1ga3lufukd30qeXCf g+GtSBPAZ2CDHBwnwsuDhjS3tUOrQg== =8Ysw -----END PGP SIGNATURE----- --=-JFZC1w1yDFGWGgHAary2--