From: Kei Kebreau <kkebreau@posteo.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 34921-done@debbugs.gnu.org
Subject: bug#34921: [PATCH] gnu: Add adanaxis-mush and adanaxisgpl.
Date: Tue, 26 Mar 2019 21:02:58 -0400 [thread overview]
Message-ID: <87bm1xw2m5.fsf@posteo.net> (raw)
In-Reply-To: <87r2axv7li.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 23 Mar 2019 18:11:37 +0100")
[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hello,
>
> Kei Kebreau <kkebreau@posteo.net> skribis:
>
>> * gnu/packages/games.scm (adanaxis-mush, adanaxisgpl): New variables.
>
> [...]
>
>> +;; Data package for adanaxisgpl.
>> +(define adanaxis-mush
>> + (let ((name "adanaxis-mush")
>> + (version "1.1.0"))
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append "http://www.mushware.com/files/"
>> + name "-" version ".tar.gz"))
>
> There seems to be a consensus that using ‘name’ to build file names like
> this isn’t great, so I’d suggest not doing it. :-)
>
>> + (uri (string-append "http://www.mushware.com/files/"
>> + name "-" version ".tar.gz"))
>
> Ditto.
>
Noted!
>> + (snippet
>> + '(begin
>> + ;; Necessary for building with gcc >=4.7.
>> + (substitute* "src/Mushcore/MushcoreSingleton.h"
>> + (("SingletonPtrSet\\(new SingletonType\\);")
>> + "MushcoreSingleton::SingletonPtrSet(new SingletonType);"))
>> + ;; Avoid an "invalid conversion from const char* to char*" error.
>> + (substitute* "src/Platform/X11/PlatformMiscUtils.cpp"
>> + (("char \\*end, \\*result;")
>> + (string-append "const char *end;"
>> + "\n"
>> + "char *result;")))))))
>
> Please return #t.
>
Done.
>> + (license license:gpl2)))
>
> If it’s v2-only, go for it!
>
> Thank you,
> Ludo’.
Pushed! Thank you for reviewing!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2019-03-27 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 19:57 [bug#34921] [PATCH] gnu: Add adanaxis-mush and adanaxisgpl Kei Kebreau
2019-03-23 17:11 ` Ludovic Courtès
2019-03-27 1:02 ` Kei Kebreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bm1xw2m5.fsf@posteo.net \
--to=kkebreau@posteo.net \
--cc=34921-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.