From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:38281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8wz6-0002ke-8B for guix-patches@gnu.org; Tue, 26 Mar 2019 21:04:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h8wz4-0002yH-La for guix-patches@gnu.org; Tue, 26 Mar 2019 21:04:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47170) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h8wz4-0002yB-EQ for guix-patches@gnu.org; Tue, 26 Mar 2019 21:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h8wz4-0005sX-6L for guix-patches@gnu.org; Tue, 26 Mar 2019 21:04:02 -0400 Subject: bug#34921: [PATCH] gnu: Add adanaxis-mush and adanaxisgpl. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Kei Kebreau References: <20190319195734.2680-1-kkebreau@posteo.net> <87r2axv7li.fsf@gnu.org> Date: Tue, 26 Mar 2019 21:02:58 -0400 In-Reply-To: <87r2axv7li.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 23 Mar 2019 18:11:37 +0100") Message-ID: <87bm1xw2m5.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 34921-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hello, > > Kei Kebreau skribis: > >> * gnu/packages/games.scm (adanaxis-mush, adanaxisgpl): New variables. > > [...] > >> +;; Data package for adanaxisgpl. >> +(define adanaxis-mush >> + (let ((name "adanaxis-mush") >> + (version "1.1.0")) >> + (origin >> + (method url-fetch) >> + (uri (string-append "http://www.mushware.com/files/" >> + name "-" version ".tar.gz")) > > There seems to be a consensus that using =E2=80=98name=E2=80=99 to build = file names like > this isn=E2=80=99t great, so I=E2=80=99d suggest not doing it. :-) > >> + (uri (string-append "http://www.mushware.com/files/" >> + name "-" version ".tar.gz")) > > Ditto. > Noted! >> + (snippet >> + '(begin >> + ;; Necessary for building with gcc >=3D4.7. >> + (substitute* "src/Mushcore/MushcoreSingleton.h" >> + (("SingletonPtrSet\\(new SingletonType\\);") >> + "MushcoreSingleton::SingletonPtrSet(new SingletonType);")) >> + ;; Avoid an "invalid conversion from const char* to char*" e= rror. >> + (substitute* "src/Platform/X11/PlatformMiscUtils.cpp" >> + (("char \\*end, \\*result;") >> + (string-append "const char *end;" >> + "\n" >> + "char *result;"))))))) > > Please return #t. > Done. >> + (license license:gpl2))) > > If it=E2=80=99s v2-only, go for it! > > Thank you, > Ludo=E2=80=99. Pushed! Thank you for reviewing! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlyay8IACgkQ5qXuPBlG eg3SHg//TmXbiio3DJpNBjdBqd31Yd01p795vIsw+izrl84UaWJuxRRT1aKTGo3t tCrwgJfzqYNqMmdrSWxT/VOQNZ4gklFtOS+Mc26Ahy1KYw1kxT3KSdF1FzRLz1jt 87r85AlFxXUziBiLSyDbhF7rz+irZgIcn2foIaYi15IUl9VOXORTgCkaC7jOLVX9 QCILZeqaav/dxMScqq51mahaiShEMepW9M5Gs79C51I/k9qfDHSSzyLpucVyGdzJ jQUNnJiqeUb1Rjnt15gradQHcMuJYuhPp67YJyOwo3+99CtyRuQMQc7gE3uu60tJ jWPLQ/FayBXYUcTw0jjwgtqiaInZSbheZQvXUfzqsf4HCxNaSMUk8TJ1WYxVqt90 NP14QVLCTnX6KtL3DPpkn0VHDbu/ZX/0QayDT4TPBvLdZDfj+LcpD0dsmAokRZqN TZzSNAifPc+GdN76oaBc617zQ2IBk6LdJu/MBjKK1opBRmiTkINCI/JQi+1xsq2c MirtSR8yQJGxjLKAL0uPOdzMbhkziIu1uyJz/x9/HQSDJaVeacN9CwNLvk25S+zW nHLY0v2Q+uvKzYgDRPPpsasN8YKYolIKwNwBKYyQnUcTrr/Wj5YgBfPimda/Ld99 GlAmg/WLrGJgE3IYLBBFoX9xMThHPxJcxcUwziUwbAiTIC9W+Gk= =xyHQ -----END PGP SIGNATURE----- --=-=-=--