Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> Kei Kebreau <kkebreau@posteo.net> skribis:
>
>> * gnu/packages/games.scm (adanaxis-mush, adanaxisgpl): New variables.
>
> [...]
>
>> +;; Data package for adanaxisgpl.
>> +(define adanaxis-mush
>> +  (let ((name "adanaxis-mush")
>> +        (version "1.1.0"))
>> +    (origin
>> +      (method url-fetch)
>> +      (uri (string-append "http://www.mushware.com/files/"
>> +                          name "-" version ".tar.gz"))
>
> There seems to be a consensus that using ‘name’ to build file names like
> this isn’t great, so I’d suggest not doing it.  :-)
>
>> +       (uri (string-append "http://www.mushware.com/files/"
>> +                           name "-" version ".tar.gz"))
>
> Ditto.
>

Noted!

>> +       (snippet
>> +        '(begin
>> +           ;; Necessary for building with gcc >=4.7.
>> +           (substitute* "src/Mushcore/MushcoreSingleton.h"
>> +             (("SingletonPtrSet\\(new SingletonType\\);")
>> +              "MushcoreSingleton::SingletonPtrSet(new SingletonType);"))
>> +           ;; Avoid an "invalid conversion from const char* to char*" error.
>> +           (substitute* "src/Platform/X11/PlatformMiscUtils.cpp"
>> +             (("char \\*end, \\*result;")
>> +              (string-append "const char *end;"
>> +                             "\n"
>> +                             "char *result;")))))))
>
> Please return #t.
>

Done.

>> +    (license license:gpl2)))
>
> If it’s v2-only, go for it!
>
> Thank you,
> Ludo’.

Pushed! Thank you for reviewing!