[bug#35015] [PATCH] gnu: qjackctl: Re-enable xunique.

[bug#35015] [PATCH] gnu: qjackctl: Re-enable xunique.

[Pierre Langlois]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

Hello,

I realised version 0.5.6 of qjackctl appears to have fixed the xunique
bug that was causing X hanging when using tiling window managers!

https://github.com/rncbc/qjackctl/blob/d54a1da43fa197da04d676a110f36a1d4c062252/ChangeLog#L9

Thanks,
Pierre


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-qjackctl-Re-enable-xunique.patch --]
[-- Type: text/x-patch, Size: 1304 bytes --]

From 9c61af1a5ae548594016dcc50f1c5d125048eb5d Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Tue, 26 Mar 2019 22:48:11 +0000
Subject: [PATCH] gnu: qjackctl: Re-enable xunique.

It looks like version 0.5.6 fixed the problem with tiling window manager.

* gnu/packages/audio.scm (qjackctl)[arguments]: Remove "--disable-xunique"
from configure-flags.
---
 gnu/packages/audio.scm | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index a38e77c996..aa99382f79 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2130,11 +2130,7 @@ different audio devices such as ALSA or PulseAudio.")
                 "0wlmbb9m7cf3wr7c2h2hji18592x2b119m7mx85wksjs6rjaq2mj"))))
     (build-system gnu-build-system)
     (arguments
-     '(#:tests? #f                      ; no check target
-       ;; Disable xunique to prevent X hanging when starting qjackctl in
-       ;; tiling window managers such as StumpWM or i3
-       ;; (see https://github.com/rncbc/qjackctl/issues/13).
-       #:configure-flags '("--disable-xunique")))
+     '(#:tests? #f))                    ; no check target
     (inputs
      `(("jack" ,jack-1)
        ("alsa-lib" ,alsa-lib)
--
2.21.0

bug#35015: [PATCH] gnu: qjackctl: Re-enable xunique.

[Ricardo Wurmus]

Pierre Langlois <pierre.langlois@gmx.com> writes:

> Hello,
>
> I realised version 0.5.6 of qjackctl appears to have fixed the xunique
> bug that was causing X hanging when using tiling window managers!
>
> https://github.com/rncbc/qjackctl/blob/d54a1da43fa197da04d676a110f36a1d4c062252/ChangeLog#L9

Thanks.  I pushed this to the master branch with commit 4dcf221c85.

-- 
Ricardo