all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Pierre Langlois <pierre.langlois@gmx.com>
To: 35015@debbugs.gnu.org
Subject: [bug#35015] [PATCH] gnu: qjackctl: Re-enable xunique.
Date: Tue, 26 Mar 2019 22:54:08 +0000	[thread overview]
Message-ID: <87bm1xdz73.fsf@gmx.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

Hello,

I realised version 0.5.6 of qjackctl appears to have fixed the xunique
bug that was causing X hanging when using tiling window managers!

https://github.com/rncbc/qjackctl/blob/d54a1da43fa197da04d676a110f36a1d4c062252/ChangeLog#L9

Thanks,
Pierre


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-qjackctl-Re-enable-xunique.patch --]
[-- Type: text/x-patch, Size: 1304 bytes --]

From 9c61af1a5ae548594016dcc50f1c5d125048eb5d Mon Sep 17 00:00:00 2001
From: Pierre Langlois <pierre.langlois@gmx.com>
Date: Tue, 26 Mar 2019 22:48:11 +0000
Subject: [PATCH] gnu: qjackctl: Re-enable xunique.

It looks like version 0.5.6 fixed the problem with tiling window manager.

* gnu/packages/audio.scm (qjackctl)[arguments]: Remove "--disable-xunique"
from configure-flags.
---
 gnu/packages/audio.scm | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index a38e77c996..aa99382f79 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2130,11 +2130,7 @@ different audio devices such as ALSA or PulseAudio.")
                 "0wlmbb9m7cf3wr7c2h2hji18592x2b119m7mx85wksjs6rjaq2mj"))))
     (build-system gnu-build-system)
     (arguments
-     '(#:tests? #f                      ; no check target
-       ;; Disable xunique to prevent X hanging when starting qjackctl in
-       ;; tiling window managers such as StumpWM or i3
-       ;; (see https://github.com/rncbc/qjackctl/issues/13).
-       #:configure-flags '("--disable-xunique")))
+     '(#:tests? #f))                    ; no check target
     (inputs
      `(("jack" ,jack-1)
        ("alsa-lib" ,alsa-lib)
--
2.21.0


             reply	other threads:[~2019-03-26 23:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 22:54 Pierre Langlois [this message]
2019-03-26 23:10 ` bug#35015: [PATCH] gnu: qjackctl: Re-enable xunique Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bm1xdz73.fsf@gmx.com \
    --to=pierre.langlois@gmx.com \
    --cc=35015@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.