Re: [PATCH 2/3] profiles: Add fonts-dir-file hook.

[ludo@gnu.org (Ludovic Courtès)]

Alex Kost <alezost@gmail.com> skribis:

> Ludovic Courtès (2016-07-05 17:31 +0300) wrote:
>
>> Alex Kost <alezost@gmail.com> skribis:
>>
>>> Ludovic Courtès (2016-07-02 17:34 +0300) wrote:
>>>
>>>> Alex Kost <alezost@gmail.com> skribis:
>>>>
>>>>> * guix/profiles.scm (fonts-dir-file): New procedure.
>>>>> (%default-profile-hooks): Add it.
>>>>
>>>> [...]
>>>>
>>>> A potential problem with this hook is that it pulls mkfontscale and
>>>> mkfontdir regardless of whether they are needed; I can’t really think of
>>>> a way to avoid it though.
>>>
>>> Yes, I also don't like it.  We have the same problem with
>>> 'info-file-dir' hook: it always pulls texinfo and gzip, but not all
>>> profiles include info manuals.
>>
>> Yes, but I thought it was OK to make these mandatory dependencies.
>>
>> The closure of mkfontscale + mkfontdir is small; it’s slightly annoying
>> for someone building from source because you have to build a few X11
>> libraries, but it’s not that much either (‘guix graph’ shows just a few
>> boxes.)
>>
>> So this hook is probably fine, after all.
>>
>> What do people think?
>
> Since there were no objections in 2 weeks, I think it's OK to commit
> this 'fonts-dir-file' hook, right?

I think so!

Ludo’.