From: Alex Kost <alezost@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/3] profiles: Add fonts-dir-file hook.
Date: Fri, 22 Jul 2016 09:59:17 +0300 [thread overview]
Message-ID: <87invyrwe2.fsf@gmail.com> (raw)
In-Reply-To: <87r3b8w40o.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 05 Jul 2016 16:31:03 +0200")
Ludovic Courtès (2016-07-05 17:31 +0300) wrote:
> Alex Kost <alezost@gmail.com> skribis:
>
>> Ludovic Courtès (2016-07-02 17:34 +0300) wrote:
>>
>>> Alex Kost <alezost@gmail.com> skribis:
>>>
>>>> * guix/profiles.scm (fonts-dir-file): New procedure.
>>>> (%default-profile-hooks): Add it.
>>>
>>> [...]
>>>
>>> A potential problem with this hook is that it pulls mkfontscale and
>>> mkfontdir regardless of whether they are needed; I can’t really think of
>>> a way to avoid it though.
>>
>> Yes, I also don't like it. We have the same problem with
>> 'info-file-dir' hook: it always pulls texinfo and gzip, but not all
>> profiles include info manuals.
>
> Yes, but I thought it was OK to make these mandatory dependencies.
>
> The closure of mkfontscale + mkfontdir is small; it’s slightly annoying
> for someone building from source because you have to build a few X11
> libraries, but it’s not that much either (‘guix graph’ shows just a few
> boxes.)
>
> So this hook is probably fine, after all.
>
> What do people think?
Since there were no objections in 2 weeks, I think it's OK to commit
this 'fonts-dir-file' hook, right?
--
Alex
next prev parent reply other threads:[~2016-07-22 6:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 9:27 [PATCH 0/3] Generate "<profile>/share/fonts/truetype/fonts.dir" file Alex Kost
2016-07-01 9:27 ` [PATCH 1/3] gnu: mkfontdir: Do not propagate 'mkfontscale' Alex Kost
2016-07-02 14:26 ` Ludovic Courtès
2016-07-01 9:27 ` [PATCH 2/3] profiles: Add fonts-dir-file hook Alex Kost
2016-07-02 14:34 ` Ludovic Courtès
2016-07-02 19:19 ` Alex Kost
2016-07-05 14:31 ` Ludovic Courtès
2016-07-06 19:41 ` Alex Kost
2016-07-22 6:59 ` Alex Kost [this message]
2016-07-24 17:09 ` Ludovic Courtès
2016-07-25 14:26 ` Alex Kost
2016-07-01 9:27 ` [PATCH 3/3] doc: Describe how to make X server find TrueType fonts Alex Kost
2016-07-02 14:38 ` Ludovic Courtès
2016-07-02 19:22 ` Alex Kost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87invyrwe2.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.