From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH 2/3] profiles: Add fonts-dir-file hook. Date: Sun, 24 Jul 2016 19:09:02 +0200 Message-ID: <87a8h7arpt.fsf@gnu.org> References: <20160701092730.2265-1-alezost@gmail.com> <20160701092730.2265-3-alezost@gmail.com> <87fursf6rf.fsf@gnu.org> <87lh1jalvm.fsf@gmail.com> <87r3b8w40o.fsf@gnu.org> <87invyrwe2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40191) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRMtr-0002XC-9y for guix-devel@gnu.org; Sun, 24 Jul 2016 13:09:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRMtm-0003z7-67 for guix-devel@gnu.org; Sun, 24 Jul 2016 13:09:10 -0400 In-Reply-To: <87invyrwe2.fsf@gmail.com> (Alex Kost's message of "Fri, 22 Jul 2016 09:59:17 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel@gnu.org Alex Kost skribis: > Ludovic Court=C3=A8s (2016-07-05 17:31 +0300) wrote: > >> Alex Kost skribis: >> >>> Ludovic Court=C3=A8s (2016-07-02 17:34 +0300) wrote: >>> >>>> Alex Kost skribis: >>>> >>>>> * guix/profiles.scm (fonts-dir-file): New procedure. >>>>> (%default-profile-hooks): Add it. >>>> >>>> [...] >>>> >>>> A potential problem with this hook is that it pulls mkfontscale and >>>> mkfontdir regardless of whether they are needed; I can=E2=80=99t reall= y think of >>>> a way to avoid it though. >>> >>> Yes, I also don't like it. We have the same problem with >>> 'info-file-dir' hook: it always pulls texinfo and gzip, but not all >>> profiles include info manuals. >> >> Yes, but I thought it was OK to make these mandatory dependencies. >> >> The closure of mkfontscale + mkfontdir is small; it=E2=80=99s slightly a= nnoying >> for someone building from source because you have to build a few X11 >> libraries, but it=E2=80=99s not that much either (=E2=80=98guix graph=E2= =80=99 shows just a few >> boxes.) >> >> So this hook is probably fine, after all. >> >> What do people think? > > Since there were no objections in 2 weeks, I think it's OK to commit > this 'fonts-dir-file' hook, right? I think so! Ludo=E2=80=99.