* [bug#29137] [PATCH] gnu: Add python-clf.
@ 2017-11-03 16:37 Oleg Pykhalov
2017-11-05 16:16 ` Marius Bakke
0 siblings, 1 reply; 6+ messages in thread
From: Oleg Pykhalov @ 2017-11-03 16:37 UTC (permalink / raw)
To: 29137
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1: [PATCH] gnu: Add python-clf. --]
[-- Type: text/x-patch, Size: 1572 bytes --]
From 96a78a88650481961083541c0cc93ef8c082c6bf Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Fri, 3 Nov 2017 18:39:17 +0300
Subject: [PATCH] gnu: Add python-clf.
* gnu/packages/web.scm (python-clf): New variable.
---
gnu/packages/web.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index eea8bb63a..eed120eb2 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -5170,6 +5170,31 @@ internetarchive python module for programatic access to archive.org.")
(package-with-python2
(strip-python2-variant python-internetarchive)))
+(define-public python-clf
+ (package
+ (name "python-clf")
+ (version "0.5.7")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "clf" version))
+ (sha256
+ (base32
+ "0zlkzqnpz7a4iavsq5vaz0nf5nr7qm5znpg1vlpz6rwnx6hikjdb"))))
+ (build-system python-build-system)
+ (propagated-inputs
+ `(("python-docopt" ,python-docopt)
+ ("python-pygments" ,python-pygments)
+ ("python-requests" ,python-requests)))
+ (home-page "https://github.com/ncrocfer/clf")
+ (synopsis "Search code snippets on @url{commandlinefu.com}")
+ (description "@code{clf} is a command line tool for searching code
+snippets on @url{commandlinefu.com}")
+ (license l:expat)))
+
+(define-public python2-clf
+ (package-with-python2 python-clf))
+
(define-public r-shiny
(package
(name "r-shiny")
--
2.14.3
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread* [bug#29137] [PATCH] gnu: Add python-clf.
2017-11-03 16:37 [bug#29137] [PATCH] gnu: Add python-clf Oleg Pykhalov
@ 2017-11-05 16:16 ` Marius Bakke
2017-11-17 17:09 ` Oleg Pykhalov
0 siblings, 1 reply; 6+ messages in thread
From: Marius Bakke @ 2017-11-05 16:16 UTC (permalink / raw)
To: Oleg Pykhalov, 29137
[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]
Oleg Pykhalov <go.wigust@gmail.com> writes:
> * gnu/packages/web.scm (python-clf): New variable.
[...]
> +(define-public python-clf
> + (package
> + (name "python-clf")
> + (version "0.5.7")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "clf" version))
> + (sha256
> + (base32
> + "0zlkzqnpz7a4iavsq5vaz0nf5nr7qm5znpg1vlpz6rwnx6hikjdb"))))
> + (build-system python-build-system)
> + (propagated-inputs
> + `(("python-docopt" ,python-docopt)
> + ("python-pygments" ,python-pygments)
> + ("python-requests" ,python-requests)))
> + (home-page "https://github.com/ncrocfer/clf")
I noticed in the '.travis.yml' that it has a test suite that can be run
with 'nosetests'. Can you try overriding the check phase with one that
runs it? That way we are likely to catch regressions early.
> + (synopsis "Search code snippets on @url{commandlinefu.com}")
> + (description "@code{clf} is a command line tool for searching code
> +snippets on @url{commandlinefu.com}")
Note: descriptions should end with a punctuation. I think I'd also add
http:// to the @url{}s here for clarity.
The rest LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* [bug#29137] [PATCH] gnu: Add python-clf.
2017-11-05 16:16 ` Marius Bakke
@ 2017-11-17 17:09 ` Oleg Pykhalov
2017-11-17 19:44 ` Oleg Pykhalov
2017-11-19 17:14 ` Marius Bakke
0 siblings, 2 replies; 6+ messages in thread
From: Oleg Pykhalov @ 2017-11-17 17:09 UTC (permalink / raw)
To: Marius Bakke; +Cc: 29137
[-- Attachment #1.1: Type: text/plain, Size: 1204 bytes --]
Hello Marius,
Apologies for the late reply and thank you for review!
Marius Bakke <mbakke@fastmail.com> writes:
> Oleg Pykhalov <go.wigust@gmail.com> writes:
>
>> * gnu/packages/web.scm (python-clf): New variable.
>
> [...]
>
>> +(define-public python-clf
>> + (package
>> + (name "python-clf")
>> + (version "0.5.7")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (pypi-uri "clf" version))
>> + (sha256
>> + (base32
>> + "0zlkzqnpz7a4iavsq5vaz0nf5nr7qm5znpg1vlpz6rwnx6hikjdb"))))
>> + (build-system python-build-system)
>> + (propagated-inputs
>> + `(("python-docopt" ,python-docopt)
>> + ("python-pygments" ,python-pygments)
>> + ("python-requests" ,python-requests)))
>> + (home-page "https://github.com/ncrocfer/clf")
>
> I noticed in the '.travis.yml' that it has a test suite that can be run
> with 'nosetests'. Can you try overriding the check phase with one that
> runs it? That way we are likely to catch regressions early.
Release tarball from pypi doesn't include test_clf.py. So I pulled it
from git master branch. Almost all tests require internet connection.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: [PATCH] gnu: Add python-clf. --]
[-- Type: text/x-patch, Size: 2844 bytes --]
From d347266c2ceac106b13e114520c80ea6acf7d1b9 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Fri, 3 Nov 2017 18:39:17 +0300
Subject: [PATCH] gnu: Add python-clf.
* gnu/packages/web.scm (python-clf): New variable.
---
gnu/packages/web.scm | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 52 insertions(+)
diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index a78f5b6f0..98708f335 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -5203,6 +5203,58 @@ internetarchive python module for programatic access to archive.org.")
(package-with-python2
(strip-python2-variant python-internetarchive)))
+(define-public python-clf
+ (let ((commit-test-clf "d01d25923c599d3261910f79fb948825b4270d07")) ; 0.5.7
+ (package
+ (name "python-clf")
+ (version "0.5.7")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "clf" version))
+ (sha256
+ (base32
+ "0zlkzqnpz7a4iavsq5vaz0nf5nr7qm5znpg1vlpz6rwnx6hikjdb"))))
+ (build-system python-build-system)
+ (propagated-inputs
+ `(("python-docopt" ,python-docopt)
+ ("python-pygments" ,python-pygments)
+ ("python-requests" ,python-requests)
+ ("python-nose" ,python-nose)
+ ("python-lxml" ,python-lxml)
+ ("python-pyaml" ,python-pyaml)))
+ (inputs
+ `(("test-clf"
+ ,(origin
+ (method url-fetch)
+ (uri (string-append "https://raw.githubusercontent.com"
+ "/ncrocfer/clf/" commit-test-clf
+ "/test_clf.py"))
+ (sha256
+ (base32
+ "19lr5zdzsmxgkg7wrjq1yzkiahd03wi4k3dskssyhmjls8c10nqd"))))))
+ (arguments
+ '(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'get-tests
+ (lambda _
+ (copy-file (assoc-ref %build-inputs "test-clf") "test_clf.py")))
+ (replace 'check
+ (lambda _
+ (zero? (system* "nosetests"
+ ;; These tests require internet connection
+ "--exclude=test_browse"
+ "--exclude=test_command"
+ "--exclude=test_search")))))))
+ (home-page "https://github.com/ncrocfer/clf")
+ (synopsis "Search code snippets on @url{commandlinefu.com}")
+ (description "@code{clf} is a command line tool for searching code
+snippets on @url{https://commandlinefu.com}")
+ (license l:expat))))
+
+(define-public python2-clf
+ (package-with-python2 python-clf))
+
(define-public r-shiny
(package
(name "r-shiny")
--
2.15.0
[-- Attachment #1.3: Type: text/plain, Size: 375 bytes --]
>> + (synopsis "Search code snippets on @url{commandlinefu.com}")
>> + (description "@code{clf} is a command line tool for searching code
>> +snippets on @url{commandlinefu.com}")
>
> Note: descriptions should end with a punctuation.
Ouch, "guix lint" didn't spot this.
> I think I'd also add http:// to the @url{}s here for clarity.
Sure, added "https://".
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread* [bug#29137] [PATCH] gnu: Add python-clf.
2017-11-17 17:09 ` Oleg Pykhalov
@ 2017-11-17 19:44 ` Oleg Pykhalov
2017-11-19 17:14 ` Marius Bakke
1 sibling, 0 replies; 6+ messages in thread
From: Oleg Pykhalov @ 2017-11-17 19:44 UTC (permalink / raw)
To: Marius Bakke; +Cc: 29137
Oh sorry, I forgot to insert a dot at the end of the description.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#29137] [PATCH] gnu: Add python-clf.
2017-11-17 17:09 ` Oleg Pykhalov
2017-11-17 19:44 ` Oleg Pykhalov
@ 2017-11-19 17:14 ` Marius Bakke
2017-11-20 6:33 ` Oleg Pykhalov
1 sibling, 1 reply; 6+ messages in thread
From: Marius Bakke @ 2017-11-19 17:14 UTC (permalink / raw)
To: Oleg Pykhalov; +Cc: 29137
[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]
Oleg Pykhalov <go.wigust@gmail.com> writes:
> Hello Marius,
>
> Apologies for the late reply and thank you for review!
>
> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Oleg Pykhalov <go.wigust@gmail.com> writes:
>>
>>> * gnu/packages/web.scm (python-clf): New variable.
>>
>> [...]
>>
>>> +(define-public python-clf
>>> + (package
>>> + (name "python-clf")
>>> + (version "0.5.7")
>>> + (source
>>> + (origin
>>> + (method url-fetch)
>>> + (uri (pypi-uri "clf" version))
>>> + (sha256
>>> + (base32
>>> + "0zlkzqnpz7a4iavsq5vaz0nf5nr7qm5znpg1vlpz6rwnx6hikjdb"))))
>>> + (build-system python-build-system)
>>> + (propagated-inputs
>>> + `(("python-docopt" ,python-docopt)
>>> + ("python-pygments" ,python-pygments)
>>> + ("python-requests" ,python-requests)))
>>> + (home-page "https://github.com/ncrocfer/clf")
>>
>> I noticed in the '.travis.yml' that it has a test suite that can be run
>> with 'nosetests'. Can you try overriding the check phase with one that
>> runs it? That way we are likely to catch regressions early.
>
> Release tarball from pypi doesn't include test_clf.py. So I pulled it
> from git master branch. Almost all tests require internet connection.
Odd that this file would be taken out. Anyway thanks for including it.
I wouldn't bother binding the package in a let for a variable that's
only used once as a native-input, but no strong opinion. LGTM.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-20 6:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-03 16:37 [bug#29137] [PATCH] gnu: Add python-clf Oleg Pykhalov
2017-11-05 16:16 ` Marius Bakke
2017-11-17 17:09 ` Oleg Pykhalov
2017-11-17 19:44 ` Oleg Pykhalov
2017-11-19 17:14 ` Marius Bakke
2017-11-20 6:33 ` Oleg Pykhalov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.