all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Oleg Pykhalov <go.wigust@gmail.com>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 29137@debbugs.gnu.org, 29137-done@debbugs.gnu.org
Subject: [bug#29137] [PATCH] gnu: Add python-clf.
Date: Mon, 20 Nov 2017 09:33:23 +0300	[thread overview]
Message-ID: <87wp2lsbm4.fsf@gmail.com> (raw)
In-Reply-To: <87lgj2tcln.fsf@fastmail.com> (Marius Bakke's message of "Sun, 19 Nov 2017 18:14:28 +0100")

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

Hello Marius,

Marius Bakke <mbakke@fastmail.com> writes:

>> Release tarball from pypi doesn't include test_clf.py.  So I pulled it
>> from git master branch.  Almost all tests require internet connection.
>
> Odd that this file would be taken out.  Anyway thanks for including it.
> I wouldn't bother binding the package in a let for a variable that's
> only used once as a native-input, but no strong opinion.  LGTM.

OK, then I will finally add a dot at the end of the description and add
"https://" to synopsis url.

Pushed as 036f1eedcc46e50fda525a65eef5de1797ce4f4d

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

      reply	other threads:[~2017-11-20  6:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 16:37 [bug#29137] [PATCH] gnu: Add python-clf Oleg Pykhalov
2017-11-05 16:16 ` Marius Bakke
2017-11-17 17:09   ` Oleg Pykhalov
2017-11-17 19:44     ` Oleg Pykhalov
2017-11-19 17:14     ` Marius Bakke
2017-11-20  6:33       ` Oleg Pykhalov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wp2lsbm4.fsf@gmail.com \
    --to=go.wigust@gmail.com \
    --cc=29137-done@debbugs.gnu.org \
    --cc=29137@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.