all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / Atom feed
* [bug#45754] [PATCH] gnu: Add emacs-anki-editor
@ 2021-01-10  6:07 Noah Evans via Guix-patches via
  2021-01-10 18:53 ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Noah Evans via Guix-patches via @ 2021-01-10  6:07 UTC (permalink / raw)
  To: 45754

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

---
gnu/packages/emacs-xyz.scm | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c86452fe2b..f1fabd4f17 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26423,3 +26423,32 @@ to pastebin-like services. It supports more than one service and will
failover if one service fails. More services can easily be added over time
and prefered services can easily be configured.")
(license license:gpl3+)))
+
+(define-public emacs-anki-editor
+ (let ((commit "546774a453ef4617b1bcb0d1626e415c67cc88df")
+ (revision "0")
+ (version "0.3.3"))
+ (package
+ (name "emacs-anki-editor")
+ (version (git-version version revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/louietan/anki-editor")
+ (commit commit)))
+ (sha256
+ (base32
+ "1if610hq5j8rbjh1caw5bwbgnsn231awwxqbpwvrh966kdxzl4qf"))))
+ (build-system emacs-build-system)
+ (propagated-inputs
+ `(("emacs-request" ,emacs-request)
+ ("emacs-dash" ,emacs-dash)))
+ (home-page
+ "https://github.com/louietan/anki-editor")
+ (synopsis
+ "Minor mode for making Anki cards with org-mode")
+ (description
+ "This package is for people who use Anki as SRS but would like to
+make cards in @code{org-mode}.")
+ (license license:gpl3+))))
--
2.30.0

[-- Attachment #2: Type: text/html, Size: 3137 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#45754] [PATCH] gnu: Add emacs-anki-editor
  2021-01-10  6:07 [bug#45754] [PATCH] gnu: Add emacs-anki-editor Noah Evans via Guix-patches via
@ 2021-01-10 18:53 ` Nicolas Goaziou
  2021-01-10 20:33   ` Noah Evans via Guix-patches via
  0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Goaziou @ 2021-01-10 18:53 UTC (permalink / raw)
  To: 45754; +Cc: clonex100

Hello,

Noah Evans via Guix-patches via <guix-patches@gnu.org> writes:

> +(define-public emacs-anki-editor

Thank you. Some comments follow.

You did not provide a commit message. Could you provide one? For
example,

    gnu: Add emacs-anki-editor

    * gnu/packages/emacs-xyz.scm (emacs-anki-editor): New variable.

is enough.

Also, your indentation is off. Could you use, e.g., M-q in Emacs to fix
it?

> + (let ((commit "546774a453ef4617b1bcb0d1626e415c67cc88df")
> + (revision "0")
> + (version "0.3.3"))

Could you explain why you chose the latest commit instead "0.3.3"
release? It might be because that release is more than two years old.

> + (package
> + (name "emacs-anki-editor")
> + (version (git-version version revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/louietan/anki-editor")
> + (commit commit)))

There's a

  (file-name (git-file-name name version))

missing here.

> + (sha256
> + (base32
> + "1if610hq5j8rbjh1caw5bwbgnsn231awwxqbpwvrh966kdxzl4qf"))))
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-request" ,emacs-request)
> + ("emacs-dash" ,emacs-dash)))

Could you order inputs alphabetically?

> + (synopsis
> + "Minor mode for making Anki cards with org-mode")

Could you replace org-mode with Org mode?

> + (description
> + "This package is for people who use Anki as SRS but would like to
> +make cards in @code{org-mode}.")

Could you explain in the description what is a "SRS"? Also,
@code{org-mode} should become Org mode.

You can also update your copyright line at the beginning of the file.

As the last point, could you move the package elsewhere than at the end
of the file. There, it is likely to introduce a merge conflict, e.g., if
someone also submits a package there while yours is being reviewed.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#45754] [PATCH] gnu: Add emacs-anki-editor
  2021-01-10 18:53 ` Nicolas Goaziou
@ 2021-01-10 20:33   ` Noah Evans via Guix-patches via
  2021-01-12  8:41     ` Nicolas Goaziou
  0 siblings, 1 reply; 4+ messages in thread
From: Noah Evans via Guix-patches via @ 2021-01-10 20:33 UTC (permalink / raw)
  To: 45754

Thank you for the feedback, here is an updated patch.

From 197ef9f0ebd4473cd9590bcbfd7d77781191c308 Mon Sep 17 00:00:00 2001
From: Noah Evans <noah@nevans.me>
Date: Sun, 10 Jan 2021 15:25:02 -0500
Subject: [PATCH] gnu: Add emacs-anki-editor

* gnu/packages/emacs-xyz.scm (emacs-anki-editor): New variable.
---
 gnu/packages/emacs-xyz.scm | 33 ++++++++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 76cbe7e075..2a94939a3e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -88,7 +88,7 @@
 ;;; Copyright © 2020 Nicolò Balzarotti <nicolo@nixo.xyz>
 ;;; Copyright © 2020 André A. Gomes <andremegafone@gmail.com>
 ;;; Copyright © 2020 Jonathan Rostran <rostranjj@gmail.com>
-;;; Copyright © 2020 Noah Evans <noah@nevans.me>
+;;; Copyright © 2020, 2021 Noah Evans <noah@nevans.me>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6344,6 +6344,37 @@ drill sessions to aid in memorization.  In these sessions you are shown flash
 cards created in Org mode.")
     (license license:gpl3+)))

+(define-public emacs-anki-editor
+  ;; Last release was in 2018
+  (let ((commit "546774a453ef4617b1bcb0d1626e415c67cc88df")
+        (revision "0")
+        (version "0.3.3"))
+    (package
+      (name "emacs-anki-editor")
+      (version (git-version version revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/louietan/anki-editor")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "1if610hq5j8rbjh1caw5bwbgnsn231awwxqbpwvrh966kdxzl4qf"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       `(("emacs-dash" ,emacs-dash)
+         ("emacs-request" ,emacs-request)))
+      (home-page
+       "https://github.com/louietan/anki-editor")
+      (synopsis
+       "Minor mode for making Anki cards with Org mode")
+      (description
+       "This package is for people who use Anki as a spaced repetition system
+(SRS) but would like to make cards in Org mode.")
+      (license license:gpl3+))))
+
 (define-public emacs-org-superstar
   (package
     (name "emacs-org-superstar")
--
2.30.0





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#45754] [PATCH] gnu: Add emacs-anki-editor
  2021-01-10 20:33   ` Noah Evans via Guix-patches via
@ 2021-01-12  8:41     ` Nicolas Goaziou
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou @ 2021-01-12  8:41 UTC (permalink / raw)
  To: 45754; +Cc: 45754-done, Noah Evans

Hello,

Noah Evans via Guix-patches via <guix-patches@gnu.org> writes:

> Thank you for the feedback, here is an updated patch.

I applied your patch with the following changes.
> +          (base32
> +           "1if610hq5j8rbjh1caw5bwbgnsn231awwxqbpwvrh966kdxzl4qf"))))

I moved the string on the line above.

> +      (home-page
> +       "https://github.com/louietan/anki-editor")
> +      (synopsis
> +       "Minor mode for making Anki cards with Org mode")

Same in the two cases above.

Thank you!

Regards,
-- 
Nicolas Goaziou




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-12  8:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-10  6:07 [bug#45754] [PATCH] gnu: Add emacs-anki-editor Noah Evans via Guix-patches via
2021-01-10 18:53 ` Nicolas Goaziou
2021-01-10 20:33   ` Noah Evans via Guix-patches via
2021-01-12  8:41     ` Nicolas Goaziou

all messages for Guix-related lists mirrored at yhetil.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix

Example config snippet for mirrors.


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git