From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8HTTF2NN+1+xaQAA0tVLHw (envelope-from ) for ; Sun, 10 Jan 2021 18:54:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id WPyhE2NN+1/3IwAA1q6Kng (envelope-from ) for ; Sun, 10 Jan 2021 18:54:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CAFB89403AE for ; Sun, 10 Jan 2021 18:54:26 +0000 (UTC) Received: from localhost ([::1]:49230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyfr7-0007q6-H6 for larch@yhetil.org; Sun, 10 Jan 2021 13:54:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyfqk-0007mn-Ke for guix-patches@gnu.org; Sun, 10 Jan 2021 13:54:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43400) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kyfqk-0007Rf-Ab for guix-patches@gnu.org; Sun, 10 Jan 2021 13:54:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kyfqk-0001CA-7w for guix-patches@gnu.org; Sun, 10 Jan 2021 13:54:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45754] [PATCH] gnu: Add emacs-anki-editor Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 10 Jan 2021 18:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45754 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45754@debbugs.gnu.org X-Debbugs-Original-To: Noah Evans via Guix-patches via X-Debbugs-Original-Cc: 45754@debbugs.gnu.org, Noah Evans Received: via spool by 45754-submit@debbugs.gnu.org id=B45754.16103047984526 (code B ref 45754); Sun, 10 Jan 2021 18:54:02 +0000 Received: (at 45754) by debbugs.gnu.org; 10 Jan 2021 18:53:18 +0000 Received: from localhost ([127.0.0.1]:54942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyfq1-0001Au-Vj for submit@debbugs.gnu.org; Sun, 10 Jan 2021 13:53:18 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:36535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyfq0-0001Ag-7T for 45754@debbugs.gnu.org; Sun, 10 Jan 2021 13:53:16 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id A227420006; Sun, 10 Jan 2021 18:53:08 +0000 (UTC) From: Nicolas Goaziou References: Date: Sun, 10 Jan 2021 19:53:07 +0100 In-Reply-To: (Noah Evans via Guix-patches via's message of "Sun, 10 Jan 2021 06:07:42 +0000") Message-ID: <875z44oc8c.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: clonex100@protonmail.com Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CAFB89403AE X-Spam-Score: -2.35 X-Migadu-Scanner: scn1.migadu.com X-TUID: 6DSrPsHgUt13 Hello, Noah Evans via Guix-patches via writes: > +(define-public emacs-anki-editor Thank you. Some comments follow. You did not provide a commit message. Could you provide one? For example, gnu: Add emacs-anki-editor * gnu/packages/emacs-xyz.scm (emacs-anki-editor): New variable. is enough. Also, your indentation is off. Could you use, e.g., M-q in Emacs to fix it? > + (let ((commit "546774a453ef4617b1bcb0d1626e415c67cc88df") > + (revision "0") > + (version "0.3.3")) Could you explain why you chose the latest commit instead "0.3.3" release? It might be because that release is more than two years old. > + (package > + (name "emacs-anki-editor") > + (version (git-version version revision commit)) > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/louietan/anki-editor") > + (commit commit))) There's a (file-name (git-file-name name version)) missing here. > + (sha256 > + (base32 > + "1if610hq5j8rbjh1caw5bwbgnsn231awwxqbpwvrh966kdxzl4qf")))) > + (build-system emacs-build-system) > + (propagated-inputs > + `(("emacs-request" ,emacs-request) > + ("emacs-dash" ,emacs-dash))) Could you order inputs alphabetically? > + (synopsis > + "Minor mode for making Anki cards with org-mode") Could you replace org-mode with Org mode? > + (description > + "This package is for people who use Anki as SRS but would like to > +make cards in @code{org-mode}.") Could you explain in the description what is a "SRS"? Also, @code{org-mode} should become Org mode. You can also update your copyright line at the beginning of the file. As the last point, could you move the package elsewhere than at the end of the file. There, it is likely to introduce a merge conflict, e.g., if someone also submits a package there while yours is being reviewed. Could you send an updated patch? Regards, -- Nicolas Goaziou