From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Attila Lendvai <attila@lendvai.name>, 63869-done@debbugs.gnu.org
Subject: bug#63869: [shepherd] `guix system reconfigure` forgets `herd disable mysrv`
Date: Sun, 18 Jun 2023 21:28:03 -0400 [thread overview]
Message-ID: <87a5wwtf4s.fsf@gmail.com> (raw)
In-Reply-To: <87fs6urnwo.fsf@gnu.org> ("Ludovic Courtès"'s message of "Wed, 14 Jun 2023 18:47:51 +0200")
Hi,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi Maxim & Attila,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>
> [...]
>
>>>>> When a service is stopped at the time of reconfigure, it is immediately
>>>>> replaced and then started.
>>>>>
>>>>> Replacing works by unregistering the old instance from the registry and
>>>>> registering a new one. As a side effect, you end up with an instance
>>>>> that’s enabled (see ‘service-registry’ in (shepherd services)).
>>>>>
>>>>> I never thought it could be a problem. WDYT?
>>>>
>>>> I think it probably goes against users' expectation (i.e., systemd) that
>>>> a disabled service stays disabled unless manually re-enabled (I think
>>>> that's the way it is for systemd, even when the system is upgraded?).
>>>
>>> Does systemd have a notion of enabled/disabled?
>>
>> Yes! 'systemctl disable <service>' [0]. It does stick around until the
>> user changes it, I can confirm the behavior which I've recently seen on
>> a Debian system upgrade (the service remained disabled and the updater
>> warned it wouldn't be restarted because of that).
>>
>> [0] https://www.freedesktop.org/software/systemd/man/systemctl.html#disable%20UNIT%E2%80%A6
>>
>>> I’m fine either way. We can also change it such that replacing a
>>> disabled service does not re-enable it; that’s probably more logical.
>>
>> I guess sticking to the established convention set by systemd would
>> cause the least friction down the road. If we agree on this, we should
>> reopen this bug (and eventually fix it :-)).
>
> Agreed, fixed in Shepherd commit
> 52db31e5b061440cd110da4848ab230ce09f365a.
Nifty! You rock! :-)
--
Thanks,
Maxim
prev parent reply other threads:[~2023-06-19 1:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-03 11:06 bug#63869: [shepherd] `guix system reconfigure` forgets `herd disable mysrv` Attila Lendvai
2023-06-05 7:08 ` Ludovic Courtès
2023-06-06 16:41 ` Maxim Cournoyer
2023-06-09 13:22 ` Ludovic Courtès
2023-06-09 17:41 ` Maxim Cournoyer
2023-06-14 16:47 ` Ludovic Courtès
2023-06-19 1:28 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5wwtf4s.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=63869-done@debbugs.gnu.org \
--cc=attila@lendvai.name \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.