From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wHzTF3avj2QCMAAASxT56A (envelope-from ) for ; Mon, 19 Jun 2023 03:29:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2DfJF3avj2TkHgAA9RJhRA (envelope-from ) for ; Mon, 19 Jun 2023 03:29:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3648ECD77 for ; Mon, 19 Jun 2023 03:29:26 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qB3hY-0008ON-RZ; Sun, 18 Jun 2023 21:29:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qB3hX-0008Nu-1b for bug-guix@gnu.org; Sun, 18 Jun 2023 21:29:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qB3hW-0001JJ-PS for bug-guix@gnu.org; Sun, 18 Jun 2023 21:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qB3hW-0005Ta-Ip for bug-guix@gnu.org; Sun, 18 Jun 2023 21:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63869: [shepherd] `guix system reconfigure` forgets `herd disable mysrv` Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 19 Jun 2023 01:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63869 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Attila Lendvai , 63869-done@debbugs.gnu.org Received: via spool by 63869-done@debbugs.gnu.org id=D63869.168713809320993 (code D ref 63869); Mon, 19 Jun 2023 01:29:02 +0000 Received: (at 63869-done) by debbugs.gnu.org; 19 Jun 2023 01:28:13 +0000 Received: from localhost ([127.0.0.1]:55306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qB3gi-0005SX-P1 for submit@debbugs.gnu.org; Sun, 18 Jun 2023 21:28:13 -0400 Received: from mail-qv1-f42.google.com ([209.85.219.42]:57816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qB3gg-0005SL-RC for 63869-done@debbugs.gnu.org; Sun, 18 Jun 2023 21:28:11 -0400 Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-62ffc10180aso23157986d6.3 for <63869-done@debbugs.gnu.org>; Sun, 18 Jun 2023 18:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687138085; x=1689730085; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=lZGkpUSfd0mhzhLnrdsqpEH+DhQqJRFGQUZMkuOvs7Q=; b=lSXamLd1GE9MwpAMNNofGN4xPX4fOn3v1Nmt5i5oQdPQEvagf6iqR8UGRoCFcpTbPs 8rLjP4ev8+yJO1CKoj8LWcakxpYkjvuxkQefgr30bvgjGqxKw5U0+VYE7lY7GSOcpuPd WFxcEdTbV/gQGENS/zeJIHtwVGmvLPn527cIHwBLar2XzdqvPB0grVcvNxKAi3iBoP8O 7rh6CVesINFhJRws0ks4B+iPZrQq8qo+gs4SgxkdmvFFJjPzAJKUqeG+IToJjYTMD28d WuFb3hsi+t4dSG22tlw8Hw+pAV5LFb+tKfU1bzqFICB79X/TsXVZOyQ2RsAVactaU1Pz A0lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687138085; x=1689730085; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=lZGkpUSfd0mhzhLnrdsqpEH+DhQqJRFGQUZMkuOvs7Q=; b=ecViKTX/lrcRPspW9ypiY8zEgIoFXXQKPDMcg+kjrwurTumssds4LA6XEp4EO6po5d c2DtG+e8iXbZyMJA9q8R6iLhwy0wSlQYx8tzZ1beqLAOziDDwP0XpXH+Br3zOTXi/MYi KnlbDZV4RkncoZapQA2/019/OwlYIJ0XTP1k4sKeLo6LULFJTQES4LLq9B0uTeSClAbX /8vXZLCCxrdd1XF7Giw0MIwNU7H+7jBkKjzmSDBKV7M/CtnqAu3yGpuLWbUlGoS5LmhO L5MIWSVttIj+j3LM0TZCQtpP7Fm+VzLhA9DE9HCQxk8QR20tk/xAq3ILTlANKHkBfKxk Bo7g== X-Gm-Message-State: AC+VfDw0kCb0E6P5qLrxPCp+jPlPzFGt7tm7iZSTQ27zk5nC7KmtPg4t LGC19ZgLhovgU+OzuetfyWgRC6YqM0M= X-Google-Smtp-Source: ACHHUZ6jYaHETICBioafziWpSBvNksbIGzSlkJSnElra7XuPM9Usbxeh8HtpMRL68kDvnxu2le049w== X-Received: by 2002:a05:6214:29ee:b0:630:11e:fbde with SMTP id jv14-20020a05621429ee00b00630011efbdemr7900042qvb.58.1687138084988; Sun, 18 Jun 2023 18:28:04 -0700 (PDT) Received: from hurd (dsl-10-130-100.b2b2c.ca. [72.10.130.100]) by smtp.gmail.com with ESMTPSA id s3-20020a0cb303000000b0062b35b691cdsm9980932qve.93.2023.06.18.18.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jun 2023 18:28:04 -0700 (PDT) From: Maxim Cournoyer References: <0-BRpRybKIwoQqvJIFAqQXuRYKM-U2rlt_Gn9XVlAfxUXoNw8PHqgmoQ5qRREt_sD4UffMLKEyindAKpHdYxHb5QMq1jzybHMMq6eLnkBU4=@lendvai.name> <87pm6ajsi9.fsf@gnu.org> <87jzwgczm4.fsf@gmail.com> <87fs70wz28.fsf@gnu.org> <87a5x8bkjl.fsf@gmail.com> <87fs6urnwo.fsf@gnu.org> Date: Sun, 18 Jun 2023 21:28:03 -0400 In-Reply-To: <87fs6urnwo.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Wed, 14 Jun 2023 18:47:51 +0200") Message-ID: <87a5wwtf4s.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687138166; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lZGkpUSfd0mhzhLnrdsqpEH+DhQqJRFGQUZMkuOvs7Q=; b=rir93ysBNssu/jJcLrvyKWO8auWgv4oCTv8BLzChJYCeax08LX29XvGpyItp5gvlgF5eu4 ofMzP2iH5ID7y7Yn0Y0HUkiA0eF9XTwCSz8k6doK9Gy5EpmAMO5+3tjQQGJMQ9iP3ncPn1 EfbMBrNiv+q5Ro1A5n4K3Bv0ZCA/u86c7QKZgPlF0/B6AbgAqV+gzsvDPnCzGyM65bMmJf mRiWCytvX7aBkHWnL71cbaUzymssWwa9+CjmYhgYNfGOunbjbytd0c+UmLr08ixG9Dsc5i Lt5N2SBQ4xJMdW/sSZI1zdOn2N2BlUF01egVGHC8ijin394hX7QxJIuVnaczAw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=lSXamLd1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687138166; a=rsa-sha256; cv=none; b=JpxnRBKWSLMVCLj5baC4/LJyRE4nENfzoFhRoNBukR1HeT7IjlpSGNat/pnJHf1eydKcdF XLibZt27SYRPnr0yciErnl9b0VkP5mYew0bGoRmRhFto6EVRSNa9Slk6MWcXQCqVg0UOcI A8tz8I/eT77rONnUpmgmEienqj+67A5dpHDTL8ewCCn+VKpqXylizdob6o513vbkiq1XKZ Bf3a2ZEM8JvoIGqawFm9Cmx+rCMYClsAKXvvlqQbG5WiLJ6fb8+qoL9zoJlYXemtnFmW6j 6ZLDGMhhxSWWQVoMEAqCQE8XjBIEEJ8VdmDg5xKSKfwHPwOrnu40i4v0ZzN8EA== X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.15 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=lSXamLd1; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3648ECD77 X-Spam-Score: -2.15 X-TUID: VWdd4xWqirbd Hi, Ludovic Court=C3=A8s writes: > Hi Maxim & Attila, > > Maxim Cournoyer skribis: > >> Ludovic Court=C3=A8s writes: > > [...] > >>>>> When a service is stopped at the time of reconfigure, it is immediate= ly >>>>> replaced and then started. >>>>> >>>>> Replacing works by unregistering the old instance from the registry a= nd >>>>> registering a new one. As a side effect, you end up with an instance >>>>> that=E2=80=99s enabled (see =E2=80=98service-registry=E2=80=99 in (sh= epherd services)). >>>>> >>>>> I never thought it could be a problem. WDYT? >>>> >>>> I think it probably goes against users' expectation (i.e., systemd) th= at >>>> a disabled service stays disabled unless manually re-enabled (I think >>>> that's the way it is for systemd, even when the system is upgraded?). >>> >>> Does systemd have a notion of enabled/disabled? >> >> Yes! 'systemctl disable ' [0]. It does stick around until the >> user changes it, I can confirm the behavior which I've recently seen on >> a Debian system upgrade (the service remained disabled and the updater >> warned it wouldn't be restarted because of that). >> >> [0] https://www.freedesktop.org/software/systemd/man/systemctl.html#dis= able%20UNIT%E2%80%A6 >> >>> I=E2=80=99m fine either way. We can also change it such that replacing= a >>> disabled service does not re-enable it; that=E2=80=99s probably more lo= gical. >> >> I guess sticking to the established convention set by systemd would >> cause the least friction down the road. If we agree on this, we should >> reopen this bug (and eventually fix it :-)). > > Agreed, fixed in Shepherd commit > 52db31e5b061440cd110da4848ab230ce09f365a. Nifty! You rock! :-) --=20 Thanks, Maxim