all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: 65550@debbugs.gnu.org, 宋文武 <iyzsong@member.fsf.org>, iyzsong@envs.net
Subject: [bug#65550] Don't add propagated-inputs for all outputs
Date: Thu, 31 Aug 2023 22:34:04 -0400	[thread overview]
Message-ID: <87a5u67hb7.fsf_-_@gmail.com> (raw)
In-Reply-To: <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> (Liliana Marie Prikler's message of "Sat, 26 Aug 2023 16:21:34 +0200")

Hi Liliana and 宋文武,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> Am Samstag, dem 26.08.2023 um 21:53 +0800 schrieb iyzsong@envs.net:
>> From: 宋文武 <iyzsong@member.fsf.org>
>>
>> * guix/profiles.scm (package->manifest-entry): Only include
>> propagated inputs from a package for its "dev" output, or its "out"
>> output if the package doesn't have a "dev" one.
>> ---
> I think this patch misses the most obvious use case of the out:lib
> split.  I also think that hardcoding this list is bound to fail.
>
> Instead, we could for the time being solve this with yet another
> package property.
>   '((propagate-inputs-from "lib")) ; but not out
>   '((propagate-inputs-from . ("lib"))) ; same meaning, different style
>   '((propagate-inputs-from "out" "lib")) ; but not doc
> If the property is missing, we still propagate from all outputs, as is
> currently done.

I'm rather against the proposed changes as it stands.  I think it'd lead
to a lot of noise in the code base and favor more complex splits of
packages, which I'm doubtful is worth the cost (in terms of
hackiness/complexity).

Since I've known Guix, I've appreciated that a simple 'find $(guix build
some-package) typically shows me the package whole, except perhaps for
its doc and debug symbols.  Having to know which packages have a "lib"
outputs when using them in package definitions is also not fun in my
experience (you start by adding the package, then it fails, then you
verify its outputs, then you add `(,package "lib")), and I fear going to
a "dev" output would bring the same kind of annoyance but at larger
scale.

I think we'd need to evaluate what we'd gain in terms of size reduction
a bit more carefully before moving in this direction and how it'd impact
the user experience.  E.g., if we can reduce the minimal Guix image size
by maybe 30%, that'd be nice, but if we're talking of about 5% like in
your example profile, it doesn't seem worth the complexity to me.

-- 
Thanks,
Maxim




  parent reply	other threads:[~2023-09-01  2:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-26 11:36 Don't add propagated-inputs for all outputs 宋文武
2023-08-26 13:53 ` [bug#65550] [PATCH] profiles: Don't propagate inputs for non-development packages iyzsong--- via Guix-patches via
2023-08-26 14:21   ` Liliana Marie Prikler
2023-08-27  7:30     ` 宋文武 via Guix-patches via
2023-08-27  9:31       ` Liliana Marie Prikler
2023-08-29 10:24         ` 宋文武 via Guix-patches via
2023-08-29 17:01           ` Liliana Marie Prikler
2023-08-30 10:55             ` 宋文武 via Guix-patches via
2023-09-01  2:16           ` [bug#65550] Don't add propagated-inputs for all outputs Maxim Cournoyer
2023-08-27  7:34     ` [bug#65550] [PATCH] profiles: Don't propagate inputs for non-development packages Josselin Poiret via Guix-patches via
2023-09-01  2:34     ` Maxim Cournoyer [this message]
2023-09-01 12:53       ` [bug#65550] Don't add propagated-inputs for all outputs 宋文武 via Guix-patches via
2023-09-01 15:03         ` Maxim Cournoyer
2023-09-02  0:43           ` bug#65550: " 宋文武 via Guix-patches via
2023-09-09 10:38   ` [bug#65550] [PATCH] profiles: Don't propagate inputs for non-development packages Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5u67hb7.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=65550@debbugs.gnu.org \
    --cc=iyzsong@envs.net \
    --cc=iyzsong@member.fsf.org \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.