From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id X7AnOvJN8WQYzwAAauVa8A:P1 (envelope-from ) for ; Fri, 01 Sep 2023 04:35:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id X7AnOvJN8WQYzwAAauVa8A (envelope-from ) for ; Fri, 01 Sep 2023 04:35:31 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6D3155DF61 for ; Fri, 1 Sep 2023 04:35:30 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=BzRuqJ0+; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693535730; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UkYETkI1BPE1C1olyN/uGplV7BgnowFQKdE24jWy3NA=; b=Ci4r8jfGGZ0o/ZwLBbsRgiOHsS7iPEop8dRHEj0oWk878rRPrHIP0mvrY9TaSFE4Jfij/b cTwfZ9l9tEMJDxJ3wqO5ZbkXSxDKqTj/JuiV4oiE9BLdzYhdmLtymAUvZC/djq5CQLP4Ed TjsaZSYbra9BeUnKiplVv/KnJIGErk/OYJzr5EOYEdHlcCIA6XNUU/HsaIz9lHb21sQ/wI FJoRI0PjLybir2+TjW2xFnGy1NqwfZ2AwH74czLpfxgODCjMRG8J0krRSCJWmbAa8M+v1j 3ypHE4HIryo6dMWhnBkzXuxWm/PxRasyqifFqz02DlTFGZ6DKxaC/4UUmBNbeQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=BzRuqJ0+; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693535730; a=rsa-sha256; cv=none; b=dHVo/A5/hxdtNUy/YwBPz1bjS7nCx6mq3BLwTwyhnYN2ixgqpbp+NvokJikYyYQjykILJu CiWstOi9D83US/4OtPivOLi4TynHDp6M0XcC/Ik7ETPuPnSQOB1aDzB9tVIJti+45ZLuR0 jYLHD6Q0z9pHKQFsWO2T1rhBuXGX+PKhxxwcmKLWrrvG0bD2+yju/SAB2O1wqntQ4UWius VCh1aK8QdlEQ9JT7dd8szLHNOJH83crYfAXzMcjDeI9BJ0EBATKUqyi6a4rbjVlOoZjZNJ IJ749f1V7aw8ttQ27TdORG7vyWYh66kMedyGIpf50pAnMjmuAWpllogNsEcidA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbtzz-0008Ro-En; Thu, 31 Aug 2023 22:35:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbtzx-0008RL-OK for guix-patches@gnu.org; Thu, 31 Aug 2023 22:35:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbtzp-0003vz-36 for guix-patches@gnu.org; Thu, 31 Aug 2023 22:35:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbtzx-0003Hm-LC for guix-patches@gnu.org; Thu, 31 Aug 2023 22:35:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65550] Don't add propagated-inputs for all outputs Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Sep 2023 02:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65550 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Liliana Marie Prikler Cc: 65550@debbugs.gnu.org, =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= , iyzsong@envs.net Received: via spool by 65550-submit@debbugs.gnu.org id=B65550.169353566312574 (code B ref 65550); Fri, 01 Sep 2023 02:35:01 +0000 Received: (at 65550) by debbugs.gnu.org; 1 Sep 2023 02:34:23 +0000 Received: from localhost ([127.0.0.1]:59539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbtzK-0003Gj-VJ for submit@debbugs.gnu.org; Thu, 31 Aug 2023 22:34:23 -0400 Received: from mail-qv1-xf2d.google.com ([2607:f8b0:4864:20::f2d]:44048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbtzI-0003GX-OE for 65550@debbugs.gnu.org; Thu, 31 Aug 2023 22:34:21 -0400 Received: by mail-qv1-xf2d.google.com with SMTP id 6a1803df08f44-64a70194fbeso8631036d6.0 for <65550@debbugs.gnu.org>; Thu, 31 Aug 2023 19:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693535646; x=1694140446; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=UkYETkI1BPE1C1olyN/uGplV7BgnowFQKdE24jWy3NA=; b=BzRuqJ0+0qimHxBXHWi/K7aqrZ+1rcyj/AWxKAFax0Nbuj0ZYsrmk/xZ/LF0O7HN2u 7ZqNH3j5flwtJcVAF0Dhvs3rZNw0prvtomHK1i3aR2nTNxeDvf+eFOgosnYVS4Rqyl4Z +TxeLt1iPwMuxsqpyRAWiMAC/Qmn86xiePXGEIwI3ft69jhfqUcehAEl5KW5oRTqTvkC v/QN3Lbgi6/AohMVXk52LFU6UJ8iGW6lN61BzhBxg6aFoI2s9hf2/hV//c/HZusSkbM6 p7mfjVc7PQUHfQ7loeDWI4doeKmaJ9XYRhxDXTa8JQo+vpWD4iL0i9PNBhduJQSTjAZP 3FjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693535646; x=1694140446; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UkYETkI1BPE1C1olyN/uGplV7BgnowFQKdE24jWy3NA=; b=KEs7MmNbJiLTGRZsB+frq9mljydmj5Dlr50syKksxGlsiA6zrm4qv3YznTCF+Uvul+ 84HZbIwUjM5TrzTO3JpmS/ZBlYnKAd7eF4dIuWP99RHkC5iW/iqvtc+qLfWLHGoJRw6Q IK+MAsKJCipjZFoIuYM/hQ3kn1jsVwGaIsHdofCORwePftvV5spgwtWrmeI3gbV5VYPn NDergncxA/3CKEgHsCv+FUvtY8Q8lUJmy6anWYfPvi87lugwvKBhC4WBleedWdk5JR/A 1mLF0oocSwooDU0Z0A0UBC+oiOj0h+kxuO7ZcAja9/nU4q6pu0sf8iFqSxfzcb+2rYn6 xTHA== X-Gm-Message-State: AOJu0Yzv9Y6Nd2k01zcWJeDV4vqpuCRBIKGPKEdAyluSs5YXqriDq3WJ 6PwGGSX2NMoM+L6YQvX+3iw= X-Google-Smtp-Source: AGHT+IFp0UcJ3del9z6AyZl6sEJ+lNEcYqkPXc9WVKcgIj1DO74IT6UiuoiZMn5DzYXVEumkzJeA8w== X-Received: by 2002:a0c:cb8a:0:b0:64a:b025:6a0 with SMTP id p10-20020a0ccb8a000000b0064ab02506a0mr952970qvk.41.1693535646245; Thu, 31 Aug 2023 19:34:06 -0700 (PDT) Received: from hurd (dsl-10-128-23.b2b2c.ca. [72.10.128.23]) by smtp.gmail.com with ESMTPSA id z14-20020a0cda8e000000b0063cfe9adb2csm1078269qvj.108.2023.08.31.19.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Aug 2023 19:34:05 -0700 (PDT) From: Maxim Cournoyer References: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> Date: Thu, 31 Aug 2023 22:34:04 -0400 In-Reply-To: <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> (Liliana Marie Prikler's message of "Sat, 26 Aug 2023 16:21:34 +0200") Message-ID: <87a5u67hb7.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx1.migadu.com X-Migadu-Spam-Score: -3.09 X-Spam-Score: -3.09 X-Migadu-Queue-Id: 6D3155DF61 X-TUID: 2RphQSjvoaLh Hi Liliana and =E5=AE=8B=E6=96=87=E6=AD=A6, Liliana Marie Prikler writes: > Am Samstag, dem 26.08.2023 um 21:53 +0800 schrieb iyzsong@envs.net: >> From: =E5=AE=8B=E6=96=87=E6=AD=A6 >> >> * guix/profiles.scm (package->manifest-entry): Only include >> propagated inputs from a package for its "dev" output, or its "out" >> output if the package doesn't have a "dev" one. >> --- > I think this patch misses the most obvious use case of the out:lib > split. I also think that hardcoding this list is bound to fail. > > Instead, we could for the time being solve this with yet another > package property. > '((propagate-inputs-from "lib")) ; but not out > '((propagate-inputs-from . ("lib"))) ; same meaning, different style > '((propagate-inputs-from "out" "lib")) ; but not doc > If the property is missing, we still propagate from all outputs, as is > currently done. I'm rather against the proposed changes as it stands. I think it'd lead to a lot of noise in the code base and favor more complex splits of packages, which I'm doubtful is worth the cost (in terms of hackiness/complexity). Since I've known Guix, I've appreciated that a simple 'find $(guix build some-package) typically shows me the package whole, except perhaps for its doc and debug symbols. Having to know which packages have a "lib" outputs when using them in package definitions is also not fun in my experience (you start by adding the package, then it fails, then you verify its outputs, then you add `(,package "lib")), and I fear going to a "dev" output would bring the same kind of annoyance but at larger scale. I think we'd need to evaluate what we'd gain in terms of size reduction a bit more carefully before moving in this direction and how it'd impact the user experience. E.g., if we can reduce the minimal Guix image size by maybe 30%, that'd be nice, but if we're talking of about 5% like in your example profile, it doesn't seem worth the complexity to me. --=20 Thanks, Maxim